Page MenuHomeFreeBSD

add infineon adm6996fc support on etherswitch

Authored by on Nov 11 2016, 12:59 AM.



add infineon adm6996fc support on etherswitch

Test Plan

check on Netgear WGR614Cv7

Diff Detail

Lint OK
No Unit Test Coverage
Build Status
Buildable 5944
Build 6225: arc lint + arc unit

Event Timeline retitled this revision from to add infineon adm6996fc support on etherswitch. updated this object. edited the test plan for this revision. (Show Details)
mizhka added a subscriber: mizhka.Nov 11 2016, 5:20 AM
  1. I see some "magic" constants. May be worth to add macros.
  2. DPRINTF usage: it prints function name on each call, is it useful/enough useful?
  3. "style(9)": ADM6996FC_READREG/WRITEREG - to be tab instead of space
  4. No checks on malloc results, may be NULL.
  5. Probe: can you add array of IDs to match. In future it will be easy to add IDs into array to bring support of another models.

one empty line is enough ;)

  1. add more macros.

2 This code is same as other ehterswitch code.

  1. add space.
  2. Other etherswitch code not check malloc also...
  3. Check only Product Code.
adrian accepted this revision.Nov 16 2016, 11:43 PM
adrian added a reviewer: adrian.
This revision is now accepted and ready to land.Nov 16 2016, 11:43 PM
mizhka accepted this revision.Nov 17 2016, 7:31 AM
mizhka added a reviewer: mizhka.
This revision was automatically updated to reflect the committed changes.