add infineon adm6996fc support on etherswitch
Details
Details
check on Netgear WGR614Cv7
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5917 Build 6202: arc lint + arc unit
Event Timeline
Comment Actions
- I see some "magic" constants. May be worth to add macros.
- DPRINTF usage: it prints function name on each call, is it useful/enough useful?
- "style(9)": ADM6996FC_READREG/WRITEREG - to be tab instead of space
- No checks on malloc results, may be NULL.
- Probe: can you add array of IDs to match. In future it will be easy to add IDs into array to bring support of another models.
sys/dev/etherswitch/infineon/adm6996fc.c | ||
---|---|---|
721–722 | one empty line is enough ;) |
Comment Actions
- add more macros.
2 This code is same as other ehterswitch code.
- add space.
- Other etherswitch code not check malloc also...
- Check only Product Code.