Page MenuHomeFreeBSD
Differential D8494

Add Forth script capability and fix compilation of loader install command
ClosedPublic
Actions

Authored by stevek on Nov 10 2016, 10:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 7:03 AM
Unknown Object (File)
Mon, Dec 23, 6:36 AM
Unknown Object (File)
Sun, Dec 22, 5:56 AM
Unknown Object (File)
Sat, Dec 21, 3:05 AM
Unknown Object (File)
Sat, Dec 21, 2:53 AM
Unknown Object (File)
Wed, Dec 4, 9:36 AM
Unknown Object (File)
Wed, Dec 4, 9:36 AM
Unknown Object (File)
Wed, Dec 4, 9:35 AM
View All 84 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
imp
Commits
rS308535: Add support for LOADER_RC setting in the pkgfs manifest (defaults to
rS308534: The file_loadraw function grew an argument, update install function
Summary

Add support for LOADER_RC setting in the pkgfs manifest (defaults to /loader.rc) to specify a Forth file to read from the pkgfs tarball and process by Ficl.
This allows for the tarball to do runtime things like load a platform-specific FDT blob, among other things.
The file_loadraw function grew an argument, but sys/boot/common/install.c did not get updated.

Test Plan

Used by Juniper Networks for network install images on non-x86 platforms.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5916
Build 6201: arc lint + arc unit

Event Timeline

stevek updated this revision to Diff 22134.Nov 10 2016, 10:12 PM
stevek retitled this revision from to Add Forth script capability and fix compilation of loader install command.
stevek updated this object.
stevek edited the test plan for this revision. (Show Details)
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptNov 10 2016, 10:12 PM
imp accepted this revision.Nov 11 2016, 12:03 AM
imp added a reviewer: imp.

Looks good to me, but maybe you'd do the file_loadraw() one first...

This revision is now accepted and ready to land.Nov 11 2016, 12:03 AM
stevek added a comment.EditedNov 11 2016, 1:51 AM
In D8494#176527, @imp wrote:

Looks good to me, but maybe you'd do the file_loadraw() one first...

The kernel often has to get loaded first in order to do other operations.
For example, in the case of having the loader.rc file load a FDT blob, it will not let you do that if the kernel has not been loaded already.

Or did you mean the mfs_root and kernel modules load before the loader.rc?

imp added a comment.Nov 11 2016, 2:55 AM
In D8494#176546, @stevek wrote:
In D8494#176527, @imp wrote:

Looks good to me, but maybe you'd do the file_loadraw() one first...

The kernel often has to get loaded first in order to do other operations.
For example, in the case of having the loader.rc file load a FDT blob, it will not let you do that if the kernel has not been loaded already.

Or did you mean the mfs_root and kernel modules load before the loader.rc?

I'm afraid I wasn't clear because it wasn't either of those things.

I'm thinking you should separate this change into two changes. One that's the file_loadraw() change. And a second one that's the rest of this diff. The code itself is fine. Sorry for the confusion.

stevek added a comment.Nov 11 2016, 4:37 PM
In D8494#176547, @imp wrote:

I'm afraid I wasn't clear because it wasn't either of those things.

I'm thinking you should separate this change into two changes. One that's the file_loadraw() change. And a second one that's the rest of this diff. The code itself is fine. Sorry for the confusion.

Oh, okay, sure. I'll do those as separate commits.

Closed by commit rS308534: The file_loadraw function grew an argument, update install function (authored by stevek). · Explain WhyNov 11 2016, 4:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
boot/
common/
20 lines

Diff 22134

View Options

sys/boot/common/install.c

Loading...