Page MenuHomeFreeBSD

add marvell 88e6060 support on etherswitch
ClosedPublic

Authored by yamori813_yahoo.co.jp on Oct 26 2016, 6:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 5:24 AM
Unknown Object (File)
Tue, Dec 3, 10:06 PM
Unknown Object (File)
Sun, Dec 1, 3:58 PM
Unknown Object (File)
Thu, Nov 28, 10:08 PM
Unknown Object (File)
Nov 23 2024, 12:14 PM
Unknown Object (File)
Nov 21 2024, 1:54 AM
Unknown Object (File)
Nov 9 2024, 8:19 PM
Unknown Object (File)
Nov 7 2024, 10:31 PM
Subscribers

Details

Summary

add marvell 88e6060 support on etherswitch

Test Plan

FON2201 and IO-Data WN-G54/R3

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5899
Build 6186: arc lint + arc unit

Event Timeline

yamori813_yahoo.co.jp retitled this revision from to add marvell 88e6060 support on etherswitch.
yamori813_yahoo.co.jp updated this object.
yamori813_yahoo.co.jp edited the test plan for this revision. (Show Details)
mizhka added inline comments.
sys/dev/etherswitch/e6000sw/e6060sw.c
119–121

Hi,
Does it worth to print if bootverbose?

448–451

At least "0x18" can be replaced by macro

469–471

Is it the same as: ports = (1<<(sc->numports + 1)) - (1<<i) - 1; ?

mizhka added a reviewer: mizhka.
This revision is now accepted and ready to land.Nov 9 2016, 7:23 AM

Hi @adrian, @loos. Is there any way to make automatic check diff against style(9)?

sys/dev/etherswitch/e6000sw/e6060sw.c
69–73

one of style(9) improvements is possible: add tab after #define

95–102

same - to be tab instead of space

128

space after "if"

171

space after "if"

248

space: i=0 => i = 0;

This revision now requires review to proceed.Nov 9 2016, 9:22 AM
mizhka accepted this revision.
mizhka removed a reviewer: mizhka.
mizhka added a reviewer: mizhka.
This revision is now accepted and ready to land.Nov 10 2016, 5:04 AM
adrian edited edge metadata.

Cool!

Does this need a committer to fire it off into head? I can take a look just to make sure it doesn't break anything obvious.

@yamori813_yahoo.co.jp , do you have plan to merge it with e6000sw or add VLAN support?

I'm happy with his going into the tree as-is. We can always unify these drivers more later.

Would someone mind please committing this to -head?

I'm happy with his going into the tree as-is. We can always unify these drivers more later.

Would someone mind please committing this to -head?

5 mins please... :)

This revision was automatically updated to reflect the committed changes.

@mizhka_gmail.com 88e6060 is not DOT1Q vlan support. It is Original Ingress and Egress Trailer. I think two way of support VLAN this chip. One is vlan(4) like support. Or other is interface driver code support. FON2201 original code use last one. But this is old chip I think leave alone is good. :)

I have a few questions (yeah, I'm late, I know...)

I cannot find where or how e6000sw.c is connected to build. It is specific to some platform or board ? Is there a reason to no add it to sys/conf/files ?

It seems to also support the model 88E6176 which is used on ClearFog Pro. At some point we may need to find a solution to support DOT1Q.

Do you think it is possible @yamori813_yahoo.co.jp ? (maybe with docs ?)

Nevermind about the 88e6176 comment, I was looking at the other file :/

But still, why these files are not linked to build ?