misc/py-socli: Update to 2.5
ClosedPublic
Actions

Authored by cpm on Oct 28 2016, 12:24 PM.

Details

Reviewers

AMDmi3
junovitch
koobs
feld

Commits

rP424849: misc/py-socli: Update to 2.5

Summary

misc/py-socli: Update to 2.5

- Update PORTVERSION and distinfo checksum (2.5)

Changelog:

   https://github.com/gautamkrishnar/socli/releases/tag/2.5

Reviewed_by: koobs, feld (mentors)
Approved by: feld (mentor)
DiffRev: D8372

Test Plan

portlint -ac output looks fine.
poudriere testportlogs are fine on 9.3/ia, 10.2/ia and 10.3/ia.
make test output looks fine.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

cpm updated this revision to Diff 21762.Oct 28 2016, 12:24 PM

cpm retitled this revision from to misc/py-socli: Update to 2.5.

cpm updated this object.

cpm edited the test plan for this revision. (Show Details)

cpm added reviewers: AMDmi3, feld, junovitch, koobs.

Changeset + commit log message LGTM.

Missing TEST PLAN results

portlint
testport
maketest

In D8372#174103, @koobs wrote:

Changeset + commit log message LGTM.

Missing TEST PLAN results

portlint

testport

maketest

I'm working on it :)

cpm edited the test plan for this revision. (Show Details)Oct 28 2016, 12:45 PM

cpm edited edge metadata.

Please add all Property: <foo> lines to the bottom of commit log message in SUMMARY as well (they are also reviewed)

koobs updated this object.Oct 28 2016, 12:48 PM

koobs edited the test plan for this revision. (Show Details)

In D8372#174107, @koobs wrote:

Please add all Property: <foo> lines to the bottom of commit log message in SUMMARY as well (they are also reviewed)

Thanks for this info.

@koobs,

Do you approve this review?

feld accepted this revision.Oct 28 2016, 1:54 PM

feld edited edge metadata.

This revision is now accepted and ready to land.Oct 28 2016, 1:54 PM

Closed by commit rP424849: misc/py-socli: Update to 2.5 (authored by cpm). · Explain WhyOct 28 2016, 1:59 PM

This revision was automatically updated to reflect the committed changes.

cpm mentioned this in rP424849: misc/py-socli: Update to 2.5.

Thank you very much to you both!

The commit log message in rP424849 is/was incorrect:

Reviewed by: koobs (mentor)
Approved by: feld, koobs (mentors)
Differential Revision: D8372

a) I only reviewed, but did not accept/approve
b) feld reviewed and approved, he is missing from reviewed by

This is why review SUMMARY (in phabricator) should include all Property: value lines, as I requested in D8372#174107

koobs updated this object.Oct 29 2016, 7:09 AM

koobs edited edge metadata.

In D8372#174293, @koobs wrote:
The commit log message in rP424849 is/was incorrect:
Reviewed by: koobs (mentor)
Approved by: feld, koobs (mentors)
Differential Revision: D8372
a) I only reviewed, but did not accept/approve
b) feld reviewed and approved, he is missing from reviewed by

This is why review SUMMARY (in phabricator) should include all Property: value lines, as I requested in D8372#174107