Page MenuHomeFreeBSD

Switch libpololu-avr port to GitHub sources.
ClosedPublic

Authored by jonathan on Sep 13 2016, 2:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 8:32 AM
Unknown Object (File)
Wed, Nov 13, 7:59 AM
Unknown Object (File)
Mon, Nov 11, 5:36 AM
Unknown Object (File)
Mon, Nov 11, 3:06 AM
Unknown Object (File)
Sun, Nov 10, 7:07 PM
Unknown Object (File)
Sun, Nov 10, 1:58 PM
Unknown Object (File)
Fri, Oct 18, 4:00 AM
Unknown Object (File)
Fri, Oct 18, 12:44 AM
Subscribers
None

Details

Summary

The zip files released on the Pololu website confuse portscout
(which thinks there should be a new version every day!) and use a
non-standard directory hierarchy, which requires WRKSRC to be set.
Switching to the GitHub releases (which are created by the same company,
just using GitHub mechanisms) solves both of these problems.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 5251
Build 5409: arc lint + arc unit

Event Timeline

jonathan retitled this revision from to Switch libpololu-avr port to GitHub sources..
jonathan updated this object.
jonathan added a reviewer: mat.
devel/libpololu-avr/Makefile
18–19

I'm not sure why I did not see that before, but this is very wrong.

PREFIX is where you install your stuff, LOCALBASE is where you get your dependencies from, they cannot be related.

I am not sure what you are trying to change here, but it is definitively not the way to do it.

devel/libpololu-avr/Makefile
18–19

Ah, yes, sorry, that probably wasn't the right way to do it. The goal is to get everything to install to /usr/local/avr/{include,lib} instead of /usr/local/{include/lib}. I can't set PREFIX=${PREFIX}/avr, so I think I went looking for variables containing /usr/local by default. Is there a better way to do this?

devel/libpololu-avr/Makefile
18–19

Hrm: it turns out that I only need to modify MAKE_ENV, not PREFIX. Should I create a separate review for that change, then come back to this one?

devel/libpololu-avr/Makefile
18–19

Just change everything at once :-)

  • Remove PREFIX hack from libpolou-avr.
  • Add RUN_DEPENDS to libpololu-avr.

Updated port to Fix All The Things (TM)

devel/libpololu-avr/Makefile
13

You can't use = here, either use := or use another variable and assign it to both BUILD_ and RUN_.
USES=gmake will add a build dependency which will end up as a run_depends.

jonathan marked an inline comment as done.
  • Simplify {BUILD,RUN}_DEPENDS.
mat edited edge metadata.
This revision is now accepted and ready to land.Sep 22 2016, 8:00 AM
This revision was automatically updated to reflect the committed changes.