Page MenuHomeFreeBSD
Differential D7932

[iwm] Fix iwm_poll_bit() error value check in iwm_attach().
ClosedPublic
Actions

Authored by ivadasz on Sep 18 2016, 9:29 AM.
Tags
None
Referenced Files
F141080746: D7932.id.diff
Wed, Dec 31, 3:05 PM
Unknown Object (File)
Mon, Dec 29, 7:22 AM
Unknown Object (File)
Thu, Dec 25, 9:33 AM
Unknown Object (File)
Tue, Dec 23, 9:07 AM
Unknown Object (File)
Sun, Dec 21, 1:23 PM
Unknown Object (File)
Tue, Dec 16, 6:09 PM
Unknown Object (File)
Tue, Dec 16, 8:48 AM
Unknown Object (File)
Tue, Dec 16, 2:28 AM
View All Files
Subscribers
imp

Details

Reviewers
cognet
adrian
Commits
rS306002: [iwm] Fix iwm_poll_bit() error value check in iwm_attach().
Summary

The iwm(4) iwm_poll_bit() function returns 1 on success, and 0 on failure,
whereas the iwl_poll_bit() in Linux iwlwifi returns < 0 on failure.

So the (ret < 0) check ended up ignoring any error returned by
iwm_poll_bit().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivadasz updated this revision to Diff 20435.Sep 18 2016, 9:29 AM
ivadasz retitled this revision from to [iwm] Fix iwm_poll_bit() error value check in iwm_attach()..
ivadasz updated this object.
ivadasz added reviewers: adrian, cognet.
Herald added a subscriber: imp. · View Herald TranscriptSep 18 2016, 9:29 AM
adrian accepted this revision.Sep 19 2016, 9:36 PM
adrian edited edge metadata.
This revision is now accepted and ready to land.Sep 19 2016, 9:36 PM
Closed by commit rS306002: [iwm] Fix iwm_poll_bit() error value check in iwm_attach(). (authored by ivadasz). · Explain WhySep 19 2016, 10:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
iwm/
2 lines

Diff 20502

View Options

head/sys/dev/iwm/if_iwm.c

Loading...