Page MenuHomeFreeBSD
Differential D7932

[iwm] Fix iwm_poll_bit() error value check in iwm_attach().
ClosedPublic
Actions

Authored by ivadasz on Sep 18 2016, 9:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 2, 8:23 PM
Unknown Object (File)
Tue, Sep 30, 12:53 AM
Unknown Object (File)
Sun, Sep 28, 2:16 PM
Unknown Object (File)
Fri, Sep 26, 9:44 AM
Unknown Object (File)
Fri, Sep 26, 2:00 AM
Unknown Object (File)
Thu, Sep 25, 3:57 AM
Unknown Object (File)
Sat, Sep 20, 6:53 AM
Unknown Object (File)
Wed, Sep 17, 1:57 AM
View All 91 Files
Subscribers
imp

Details

Reviewers
cognet
adrian
Commits
rS306002: [iwm] Fix iwm_poll_bit() error value check in iwm_attach().
Summary

The iwm(4) iwm_poll_bit() function returns 1 on success, and 0 on failure,
whereas the iwl_poll_bit() in Linux iwlwifi returns < 0 on failure.

So the (ret < 0) check ended up ignoring any error returned by
iwm_poll_bit().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5196
Build 5329: arc lint + arc unit

Event Timeline

ivadasz updated this revision to Diff 20435.Sep 18 2016, 9:29 AM
ivadasz retitled this revision from to [iwm] Fix iwm_poll_bit() error value check in iwm_attach()..
ivadasz updated this object.
ivadasz added reviewers: adrian, cognet.
Herald added a subscriber: imp. · View Herald TranscriptSep 18 2016, 9:29 AM
adrian accepted this revision.Sep 19 2016, 9:36 PM
adrian edited edge metadata.
This revision is now accepted and ready to land.Sep 19 2016, 9:36 PM
Closed by commit rS306002: [iwm] Fix iwm_poll_bit() error value check in iwm_attach(). (authored by ivadasz). · Explain WhySep 19 2016, 10:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
iwm/
2 lines

Diff 20435

View Options

sys/dev/iwm/if_iwm.c

Loading...