Page MenuHomeFreeBSD
Differential D7931

[iwm] Fix off-by-one check in iwm_read_firmware().
ClosedPublic
Actions

Authored by ivadasz on Sep 18 2016, 9:26 AM.
Tags
None
Referenced Files
F149087716: D7931.id20434.diff
Sun, Mar 22, 5:40 AM
F148970338: D7931.id20501.diff
Sat, Mar 21, 10:14 AM
Unknown Object (File)
Mon, Mar 9, 5:36 PM
Unknown Object (File)
Mon, Mar 9, 12:31 PM
Unknown Object (File)
Thu, Mar 5, 10:33 AM
Unknown Object (File)
Thu, Mar 5, 3:34 AM
Unknown Object (File)
Wed, Mar 4, 10:35 PM
Unknown Object (File)
Fri, Feb 27, 3:10 PM
View All Files
Subscribers
imp

Details

Reviewers
cognet
adrian
Commits
rS306001: [iwm] Fix off-by-one check in iwm_read_firmware().
Summary

This fixes a potential buffer overrun in the firmware parsing code.

Reported by: Coverity

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5195
Build 5328: arc lint + arc unit

Event Timeline

ivadasz updated this revision to Diff 20434.Sep 18 2016, 9:26 AM
ivadasz retitled this revision from to [iwm] Fix off-by-one check in iwm_read_firmware()..
ivadasz updated this object.
ivadasz added reviewers: adrian, cognet.
Herald added a subscriber: imp. · View Herald TranscriptSep 18 2016, 9:26 AM
adrian accepted this revision.Sep 19 2016, 9:36 PM
adrian edited edge metadata.
This revision is now accepted and ready to land.Sep 19 2016, 9:36 PM
Closed by commit rS306001: [iwm] Fix off-by-one check in iwm_read_firmware(). (authored by ivadasz). · Explain WhySep 19 2016, 10:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
iwm/
2 lines

Diff 20434

View Options

sys/dev/iwm/if_iwm.c

Loading...