Page MenuHomeFreeBSD
Differential D7887

net80211: improve error checking in ieee80211_parse_{wpa,rsn}
ClosedPublic
Actions

Authored by avos on Sep 13 2016, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 10:23 PM
Unknown Object (File)
Nov 5 2024, 12:48 PM
Unknown Object (File)
Oct 30 2024, 1:30 AM
Unknown Object (File)
Oct 5 2024, 7:40 PM
Unknown Object (File)
Oct 5 2024, 6:48 AM
Unknown Object (File)
Oct 5 2024, 3:36 AM
Unknown Object (File)
Oct 4 2024, 2:21 PM
Unknown Object (File)
Sep 12 2024, 8:41 PM
View All 45 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS305785: net80211: improve error checking in ieee80211_parse_{wpa,rsn}()
Summary
  • Add few checks for group/pairwise ciphers in ieee80211_parse_{wpa,rsn}.
  • Split error code and cipher value in wpa_cipher() / rsn_cipher(); current hack with (1 << 32) does not work - it's 1, not 0 (originally detected by CSA).
  • Return IEEE80211_REASON_UNSUPP_RSN_IE_VERSION instead of IEEE80211_REASON_IE_INVALID when version field is not equal to RSN_VERSION.
Test Plan

Tested with wpi(4) / urtwn(4); no visible regressions.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

avos updated this revision to Diff 20323.Sep 13 2016, 9:38 PM
avos retitled this revision from to net80211: improve error checking in ieee80211_parse_{wpa,rsn}.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptSep 13 2016, 9:38 PM
adrian accepted this revision.Sep 13 2016, 10:02 PM
adrian edited edge metadata.

looks good to me!

This revision is now accepted and ready to land.Sep 13 2016, 10:02 PM
Closed by commit rS305785: net80211: improve error checking in ieee80211_parse_{wpa,rsn}() (authored by avos). · Explain WhySep 13 2016, 10:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
net80211/
128 lines

Diff 20323

View Options

sys/net80211/ieee80211_hostap.c

Loading...