Prevent BSS from being cleared twice on BookE
ClosedPublic
Actions

Authored by int0dster_gmail.com on Aug 25 2016, 4:49 AM.

Details

Reviewers

Commits

rS304829: Prevent BSS from being cleared twice on BookE

Summary

First time BSS is cleared in booke_init(), Second time it cleared in powerpc_init().
Any variable initialized between two those guys gets wiped out what is wrong. In particular
it wipes tlb1_entries initialized by tlb1_init()

Test Plan

Build and boot the kernel

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

int0dster_gmail.com updated this revision to Diff 19659.Aug 25 2016, 4:49 AM

int0dster_gmail.com retitled this revision from to Prevent BSS from being cleared twice on BookE.

int0dster_gmail.com updated this object.

int0dster_gmail.com edited the test plan for this revision. (Show Details)

int0dster_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.

int0dster_gmail.com added a project: PowerPC.

Herald added a reviewer: jhibbits. · View Herald TranscriptAug 25 2016, 4:49 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript

Great! This was another leftover from the statically cached tlb1, where we would re initialize then reset the tlb. Since we no longer reset the tlb this zeroing is no longer needed, and is instead potentially harmful.

This revision is now accepted and ready to land.Aug 25 2016, 7:31 PM

Closed by commit rS304829: Prevent BSS from being cleared twice on BookE (authored by jhibbits). · Explain WhyAug 26 2016, 3:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

powerpc/

machdep.c

6 lines

Diff 19710

View Options

head/sys/powerpc/powerpc/machdep.c

Prevent BSS from being cleared twice on BookEClosedPublicActions