Page MenuHomeFreeBSD
Differential D7607

tlb1_init() can be called twice on BookE
ClosedPublic
Actions

Authored by int0dster_gmail.com on Aug 23 2016, 4:16 AM.
Tags
Referenced Files
F105572035: D7607.diff
Tue, Dec 17, 7:39 PM
Unknown Object (File)
Nov 7 2024, 2:15 AM
Unknown Object (File)
Oct 30 2024, 12:17 AM
Unknown Object (File)
Oct 30 2024, 12:03 AM
Unknown Object (File)
Oct 29 2024, 11:34 PM
Unknown Object (File)
Oct 29 2024, 10:30 PM
Unknown Object (File)
Oct 29 2024, 10:15 PM
Unknown Object (File)
Oct 29 2024, 6:46 PM
View All 68 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
jhibbits
Commits
rS304656: tlb1_init() can be called twice on BookE
Summary

There is no need to call tlb1_init() twice. Now it is called first time from booke_init()
and second time from powerpc_init() (where it is under BOOKE switch). Although this does not cause immediate
problems in the mainline kernel, this can lead to undesirable side effects like two TLB entries with the same
VA in the TLB1. Presence of two TLB entries with the same VA can hang CPU.

Test Plan

Add initial mapping for UART to the tlb1_init(), build and boot the kernel, ensure that mapping presents
only once (most convinient way - through Lauterbah or similar hardware debugger)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

int0dster_gmail.com updated this revision to Diff 19570.Aug 23 2016, 4:16 AM
int0dster_gmail.com retitled this revision from to tlb1_init() can be called twice on BookE.
int0dster_gmail.com updated this object.
int0dster_gmail.com edited the test plan for this revision. (Show Details)
int0dster_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.
int0dster_gmail.com added a project: PowerPC.
Herald added a reviewer: jhibbits. · View Herald TranscriptAug 23 2016, 4:16 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
jhibbits accepted this revision.Aug 23 2016, 4:31 AM
jhibbits edited edge metadata.

This was leftovers from when we cached TLB1 entries in an in-memory cache, and needed to call tlb1_init() after the BSS was initialized, to reinitialize the cache.

This revision is now accepted and ready to land.Aug 23 2016, 4:31 AM
Closed by commit rS304656: tlb1_init() can be called twice on BookE (authored by jhibbits). · Explain WhyAug 23 2016, 4:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
powerpc/
powerpc/
4 lines

Diff 19570

View Options

sys/powerpc/powerpc/machdep.c

Loading...