Apple's fork of LLVM includes features that haven't yet been merged
to the main LLVM repository, such as expanded support for -fbounds-safety.
Details
- Reviewers
brooks abhijeetsharma2002_gmail.com
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 79317 Build 76200: arc lint + arc unit
Event Timeline
Seems like a useful thing to have around.
It's a little odd to name it apple-llvm when everything else is llvm-<foo> (llvm-cheri installs CHERI LLVM and llvm-Morello installs Morello LLVM). I assume this was bootstrapped from devel/llvm21? If so, when committing, please follow my usual practice when adding LLVM ports of copying the directory unmodified and then committing the actual port on top and hooking it up. This aids git's rename detection.
| devel/apple-llvm/Makefile.LICENSE | ||
|---|---|---|
| 1 ↗ | (On Diff #192558) | This appears to be an unmodified copy of devel/llvm-devel/Makefile.LICENSE. Why? |
| devel/apple-llvm/pkg-descr | ||
| 5 ↗ | (On Diff #192558) | I fear this is going to rot quickly. |
| devel/apple-llvm/Makefile | ||
|---|---|---|
| 42 ↗ | (On Diff #192558) | clang/tools/clang-scan-deps/clang-deps-launcher.py is missing from this list. Without it stage-qa fails on its /usr/bin/env python3 shebang. |
| 662 ↗ | (On Diff #192558) | yaml2macho-core is built under lldb/tools, but this doesn't match it, so it has no %%LLDB%% in the pkg-plist, and check-plist fails on lite. Adding yaml2macho-core to the pattern should fix it. |
I can rename it to llvm-apple if that’s preferable. I don’t have a strong opinion.
I assume this was bootstrapped from devel/llvm21? If so, when committing, please follow my usual practice when adding LLVM ports of copying the directory unmodified and then committing the actual port on top and hooking it up. This aids git's rename detection.
It was actually bootstrapped from llvm-devel. Maybe I should have bootstrapped it from llvm21, I’m not sure.
Anyway, I don’t have a commit bit anymore.
| devel/apple-llvm/Makefile.LICENSE | ||
|---|---|---|
| 1 ↗ | (On Diff #192558) | It is because the licenses are the same. Are you saying it should have been copied from the llvm21 port? |
| devel/apple-llvm/pkg-descr | ||
| 5 ↗ | (On Diff #192558) | The idea is to support this project: https://wiki.freebsd.org/BoundsSafety |
I'm a bit surprised since llvm-devel doesn't contain any of the BE options. Given the information in pkg-descr I would have started with the closest port.
| devel/apple-llvm/Makefile.LICENSE | ||
|---|---|---|
| 1 ↗ | (On Diff #192558) | It should not have been copied at all (see the other LLVM ports that include devel/llvm-devel/Makefile.LICENSE rather than duplicating it). |
| devel/apple-llvm/pkg-descr | ||
| 5 ↗ | (On Diff #192558) | I mean, I think the precise versions are going to get stale. We typically include that much detail in pkg-descr. |