0.2.33
ClosedPublic
Actions

Authored by nxjoseph on Fri, Nov 6, 6:29 PM.

Project Tags

None

Referenced Files

	F177552524: D61270.1794698796.diff
	Fri, Nov 13, 11:26 PM

	F177535710: D61270.1794653437.diff
	Fri, Nov 13, 10:50 AM

Subscribers

osa

vvd

Details

Reviewers

osa
vvd

Commits

R11:4d01c9529b62: mail/hydroxide: Update 0.2.32 => 0.2.33

Summary

Hi,

Can you please review this patch? I am unsure if I can rename the rc.d script with a dash instead of an underscore.

The reason of the rename is because the source code archive extracts under ${WRKDIR}/hydroxide, whereas USE_RC_SUBR=${PORTNAME} was also needing to be placed to ${WRKDIR}/hydroxide, so a collision happens :(

Thanks in advance!

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nxjoseph requested review of this revision.Fri, Nov 6, 6:29 PM

nxjoseph created this revision.

nxjoseph edited the summary of this revision. (Show Details)

Try:

 SUB_LIST=       USER=${USERS}
+WRKSRC=         ${WRKDIR}/${PORTNAME}-${DISTVERSION}
 USERS=          ${PORTNAME}

post-extract:
        ${MV} ${WRKDIR}/${PORTNAME}/* ${WRKSRC}
        ${RM} -r ${WRKDIR}/${PORTNAME}
        @${CP} ${FILESDIR}/modules.txt ${WRKSRC}/vendor

In D61270#1404758, @vvd wrote:

Try:

 SUB_LIST=       USER=${USERS}
+WRKSRC=         ${WRKDIR}/${PORTNAME}-${DISTVERSION}
 USERS=          ${PORTNAME}

post-extract:
        ${MV} ${WRKDIR}/${PORTNAME}/* ${WRKSRC}
        ${RM} -r ${WRKDIR}/${PORTNAME}
        @${CP} ${FILESDIR}/modules.txt ${WRKSRC}/vendor

Seems to work fine except check-sanity but I suppose it's the best we can do.

Thank you.

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Nov 9, 7:59 PM

Closed by commit R11:4d01c9529b62: mail/hydroxide: Update 0.2.32 => 0.2.33. · Explain Why

This revision was automatically updated to reflect the committed changes.

nxjoseph added a commit: R11:4d01c9529b62: mail/hydroxide: Update 0.2.32 => 0.2.33.