Differential D61262
if_bnxt: set COAL_NOW only on BDs that request a completion Authored by sumit.saxena_broadcom.com on Fri, Nov 6, 10:23 AM. Project Tags None Referenced Files
Subscribers None
Details With host TX completion coalescing, COAL_NOW was set on every BD even Set it only on the BD that requests the completion.
Diff Detail
Event TimelineComment Actions This seems reasonable. But bnxt_ktls_pre_xmit() seems to use the same pattern that you're fixing here. Does it also need the same fix? Comment Actions I've run the above patch, plus diff --git a/FreeBSD/sys/dev/bnxt/bnxt_en/bnxt_ktls.c b/FreeBSD/sys/dev/bnxt/bnxt_en/bnxt_ktls.c index 982292aad2a3..79c839fc0d75 100644 --- a/FreeBSD/sys/dev/bnxt/bnxt_en/bnxt_ktls.c +++ b/FreeBSD/sys/dev/bnxt/bnxt_en/bnxt_ktls.c @@ -1783,8 +1783,8 @@ static void bnxt_ktls_pre_xmit(struct bnxt_softc *bp, struct bnxt_ring *txr, txr->running_bds + CRYPTO_PREFIX_CMD_BDS + 1); if (bp->tx_host_coal_enable) { - psbd->tx_bd_len_flags_type |= TX_BD_LONG_FLAGS_COAL_NOW; if (need_cpl) { + psbd->tx_bd_len_flags_type |= TX_BD_LONG_FLAGS_COAL_NOW; txr->running_bds = 0; } else { txr->running_bds += (CRYPTO_PREFIX_CMD_BDS + 1); Overnight on a 2x400 box serving ~720Gb/s of ktls offload, and its been fine. |