Page MenuHomeFreeBSD
Differential D910

editors/sublime: amend patches
ClosedPublic
Actions

Authored by xmj on Oct 7 2014, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 1:21 AM
Unknown Object (File)
Sat, Mar 1, 5:09 PM
Unknown Object (File)
Sat, Mar 1, 2:12 PM
Unknown Object (File)
Sat, Mar 1, 12:49 PM
Unknown Object (File)
Feb 16 2025, 1:45 PM
Unknown Object (File)
Jan 18 2025, 6:54 PM
Unknown Object (File)
Dec 7 2024, 12:45 PM
Unknown Object (File)
Sep 27 2024, 8:02 AM
View All 78 Files
Subscribers
rm

Details

Reviewers
swills
koobs
Summary

Remove an import statement in patched PackageSetupy.py that was deprecated
before python 2.7

Test Plan

http://xmj.me/freebsd/buildlogs/sublime-2.0.2_1.log

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

xmj updated this revision to Diff 1905.Oct 7 2014, 1:18 PM
xmj retitled this revision from to editors/sublime: amend patches.
xmj updated this object.
xmj edited the test plan for this revision. (Show Details)
xmj added reviewers: swills, koobs.
swills accepted this revision.Oct 7 2014, 2:09 PM
swills edited edge metadata.

Approved, looks fine.

This revision is now accepted and ready to land.Oct 7 2014, 2:09 PM
xmj closed this revision.Oct 7 2014, 2:14 PM

Committed revision 370338.

rm added a subscriber: rm.Oct 7 2014, 2:46 PM

It is work here:

Python 2.7.8 (default, Sep 25 2014, 23:51:23) 
[GCC 4.2.1 Compatible FreeBSD Clang 3.4.1 (tags/RELEASE_34/dot1-final 208032)] on freebsd11
Type "help", "copyright", "credits" or "license" for more information.
>>> from __future__ import with_statement
>>>

But it doesn't needed on python 2.7 because "with" works out of the box. Anyway, what problem this patch is solving?

Revision Contents
Changeset List

PathSize
editors/
sublime/
1 line
files/
10 lines

Diff 1905

View Options

editors/sublime/Makefile

Show First 20 Lines • Show All 744 Lines • ▼ Show 20 Linesiap_allocate_pmc(int cpu, int ri, struct pmc *pm,
uint32_t caps; uint32_t caps;
const struct pmc_md_iap_op_pmcallocate *iap; const struct pmc_md_iap_op_pmcallocate *iap;
KASSERT(cpu >= 0 && cpu < pmc_cpu_max(), KASSERT(cpu >= 0 && cpu < pmc_cpu_max(),
("[core,%d] illegal CPU %d", __LINE__, cpu)); ("[core,%d] illegal CPU %d", __LINE__, cpu));
KASSERT(ri >= 0 && ri < core_iap_npmc, KASSERT(ri >= 0 && ri < core_iap_npmc,
("[core,%d] illegal row-index value %d", __LINE__, ri)); ("[core,%d] illegal row-index value %d", __LINE__, ri));
if (a->pm_class != PMC_CLASS_IAP)
return (EINVAL);
/* check requested capabilities */ /* check requested capabilities */
caps = a->pm_caps; caps = a->pm_caps;
if ((IAP_PMC_CAPS & caps) != caps) if ((IAP_PMC_CAPS & caps) != caps)
return (EPERM); return (EPERM);
iap = &a->pm_md.pm_iap; iap = &a->pm_md.pm_iap;
ev = IAP_EVSEL_GET(iap->pm_iap_config); ev = IAP_EVSEL_GET(iap->pm_iap_config);
switch (core_cputype) { switch (core_cputype) {
▲ Show 20 Lines • Show All 584 Lines • Show Last 20 Lines
View Options

editors/sublime/files/patch-PackageSetup.py

Show First 20 Lines • Show All 744 Lines • ▼ Show 20 Linesiap_allocate_pmc(int cpu, int ri, struct pmc *pm,
uint32_t caps; uint32_t caps;
const struct pmc_md_iap_op_pmcallocate *iap; const struct pmc_md_iap_op_pmcallocate *iap;
KASSERT(cpu >= 0 && cpu < pmc_cpu_max(), KASSERT(cpu >= 0 && cpu < pmc_cpu_max(),
("[core,%d] illegal CPU %d", __LINE__, cpu)); ("[core,%d] illegal CPU %d", __LINE__, cpu));
KASSERT(ri >= 0 && ri < core_iap_npmc, KASSERT(ri >= 0 && ri < core_iap_npmc,
("[core,%d] illegal row-index value %d", __LINE__, ri)); ("[core,%d] illegal row-index value %d", __LINE__, ri));
if (a->pm_class != PMC_CLASS_IAP)
return (EINVAL);
/* check requested capabilities */ /* check requested capabilities */
caps = a->pm_caps; caps = a->pm_caps;
if ((IAP_PMC_CAPS & caps) != caps) if ((IAP_PMC_CAPS & caps) != caps)
return (EPERM); return (EPERM);
iap = &a->pm_md.pm_iap; iap = &a->pm_md.pm_iap;
ev = IAP_EVSEL_GET(iap->pm_iap_config); ev = IAP_EVSEL_GET(iap->pm_iap_config);
switch (core_cputype) { switch (core_cputype) {
▲ Show 20 Lines • Show All 584 Lines • Show Last 20 Lines