Page MenuHomeFreeBSD
Differential D910

editors/sublime: amend patches
ClosedPublic
Actions

Authored by xmj on Oct 7 2014, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 1:21 AM
Unknown Object (File)
Sat, Mar 1, 5:09 PM
Unknown Object (File)
Sat, Mar 1, 2:12 PM
Unknown Object (File)
Sat, Mar 1, 12:49 PM
Unknown Object (File)
Feb 16 2025, 1:45 PM
Unknown Object (File)
Jan 18 2025, 6:54 PM
Unknown Object (File)
Dec 7 2024, 12:45 PM
Unknown Object (File)
Sep 27 2024, 8:02 AM
View All 78 Files
Subscribers
rm

Details

Reviewers
swills
koobs
Summary

Remove an import statement in patched PackageSetupy.py that was deprecated
before python 2.7

Test Plan

http://xmj.me/freebsd/buildlogs/sublime-2.0.2_1.log

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

xmj updated this revision to Diff 1905.Oct 7 2014, 1:18 PM
xmj retitled this revision from to editors/sublime: amend patches.
xmj updated this object.
xmj edited the test plan for this revision. (Show Details)
xmj added reviewers: swills, koobs.
swills accepted this revision.Oct 7 2014, 2:09 PM
swills edited edge metadata.

Approved, looks fine.

This revision is now accepted and ready to land.Oct 7 2014, 2:09 PM
xmj closed this revision.Oct 7 2014, 2:14 PM

Committed revision 370338.

rm added a subscriber: rm.Oct 7 2014, 2:46 PM

It is work here:

Python 2.7.8 (default, Sep 25 2014, 23:51:23) 
[GCC 4.2.1 Compatible FreeBSD Clang 3.4.1 (tags/RELEASE_34/dot1-final 208032)] on freebsd11
Type "help", "copyright", "credits" or "license" for more information.
>>> from __future__ import with_statement
>>>

But it doesn't needed on python 2.7 because "with" works out of the box. Anyway, what problem this patch is solving?

Revision Contents
Changeset List

PathSize
editors/
sublime/
1 line
files/
10 lines

Diff 1905

View Options

editors/sublime/Makefile

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines
* head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml * head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml
* *
* scheme is: <major><two digit minor>Rxx * scheme is: <major><two digit minor>Rxx
* 'R' is in the range 0 to 4 if this is a release branch or * 'R' is in the range 0 to 4 if this is a release branch or
* X.0-CURRENT before releng/X.0 is created, otherwise 'R' is * X.0-CURRENT before releng/X.0 is created, otherwise 'R' is
* in the range 5 to 9. * in the range 5 to 9.
*/ */
#undef __FreeBSD_version #undef __FreeBSD_version
#define __FreeBSD_version 1300040 /* Master, propagated to newvers */ #define __FreeBSD_version 1300041 /* Master, propagated to newvers */
/* /*
* __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD, * __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD,
* which by definition is always true on FreeBSD. This macro is also defined * which by definition is always true on FreeBSD. This macro is also defined
* on other systems that use the kernel of FreeBSD, such as GNU/kFreeBSD. * on other systems that use the kernel of FreeBSD, such as GNU/kFreeBSD.
* *
* It is tempting to use this macro in userland code when we want to enable * It is tempting to use this macro in userland code when we want to enable
* kernel-specific routines, and in fact it's fine to do this in code that * kernel-specific routines, and in fact it's fine to do this in code that
▲ Show 20 Lines • Show All 296 Lines • Show Last 20 Lines
View Options

editors/sublime/files/patch-PackageSetup.py

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines
* head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml * head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml
* *
* scheme is: <major><two digit minor>Rxx * scheme is: <major><two digit minor>Rxx
* 'R' is in the range 0 to 4 if this is a release branch or * 'R' is in the range 0 to 4 if this is a release branch or
* X.0-CURRENT before releng/X.0 is created, otherwise 'R' is * X.0-CURRENT before releng/X.0 is created, otherwise 'R' is
* in the range 5 to 9. * in the range 5 to 9.
*/ */
#undef __FreeBSD_version #undef __FreeBSD_version
#define __FreeBSD_version 1300040 /* Master, propagated to newvers */ #define __FreeBSD_version 1300041 /* Master, propagated to newvers */
/* /*
* __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD, * __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD,
* which by definition is always true on FreeBSD. This macro is also defined * which by definition is always true on FreeBSD. This macro is also defined
* on other systems that use the kernel of FreeBSD, such as GNU/kFreeBSD. * on other systems that use the kernel of FreeBSD, such as GNU/kFreeBSD.
* *
* It is tempting to use this macro in userland code when we want to enable * It is tempting to use this macro in userland code when we want to enable
* kernel-specific routines, and in fact it's fine to do this in code that * kernel-specific routines, and in fact it's fine to do this in code that
▲ Show 20 Lines • Show All 296 Lines • Show Last 20 Lines