Details

Reviewers

None

Group Reviewers

portmgr

Commits

rP419511: Always include bsd.default-versions.mk in bsd.port.mk.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mat updated this revision to Diff 17808.Jun 23 2016, 2:38 PM

mat retitled this revision from to include bsd.default-versions.mk in bsd.port.mk and remove all other inclusions..

mat updated this object.

mat edited the test plan for this revision. (Show Details)

Herald added a reviewer: portmgr. · View Herald TranscriptJun 23 2016, 2:38 PM

rebase.

Herald edited edge metadata. · View Herald TranscriptJun 28 2016, 3:38 PM

I do like the idea, I haven't checked yet if the place is the right one but at first glance it looks like the place where I would have added it

rebase.

Herald edited edge metadata. · View Herald TranscriptJul 20 2016, 11:45 AM

In D6933#147423, @bapt wrote:

I do like the idea, I haven't checked yet if the place is the right one but at first glance it looks like the place where I would have added it

I put it where it made more sense, it's content is available when bsd.port.options.mk is included, I don't think the order with which b.options.m and b.default-versions.m are included matter much.

Setting WITH_OPENSSL_PORT after bsd.port.options.mk is not possible any

Herald edited edge metadata. · View Herald TranscriptJul 21 2016, 10:36 PM

Including here was too early, put it back a bit.

Herald edited edge metadata. · View Herald TranscriptJul 27 2016, 3:17 PM

Closed by commit rP419511: Always include bsd.default-versions.mk in bsd.port.mk. (authored by mat). · Explain WhyAug 3 2016, 12:10 PM

This revision was automatically updated to reflect the committed changes.

include bsd.default-versions.mk in bsd.port.mk and remove all other inclusions.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 18993

head/Mk/Uses/bdb.mk

head/Mk/Uses/firebird.mk

head/Mk/Uses/fortran.mk

head/Mk/Uses/ghostscript.mk

head/Mk/Uses/lua.mk

head/Mk/Uses/mysql.mk

head/Mk/Uses/perl5.mk

head/Mk/Uses/pgsql.mk

head/Mk/Uses/php.mk

head/Mk/Uses/python.mk

head/Mk/Uses/ssl.mk

head/Mk/Uses/tcl.mk

head/Mk/bsd.apache.mk

head/Mk/bsd.fpc.mk

head/Mk/bsd.gcc.mk

head/Mk/bsd.port.mk

head/Mk/bsd.ruby.mk

include bsd.default-versions.mk in bsd.port.mk and remove all other inclusions.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18993

head/Mk/Uses/bdb.mk

head/Mk/Uses/firebird.mk

head/Mk/Uses/fortran.mk

head/Mk/Uses/ghostscript.mk

head/Mk/Uses/lua.mk

head/Mk/Uses/mysql.mk

head/Mk/Uses/perl5.mk

head/Mk/Uses/pgsql.mk

head/Mk/Uses/php.mk

head/Mk/Uses/python.mk

head/Mk/Uses/ssl.mk

head/Mk/Uses/tcl.mk

head/Mk/bsd.apache.mk

head/Mk/bsd.fpc.mk

head/Mk/bsd.gcc.mk

head/Mk/bsd.port.mk

head/Mk/bsd.ruby.mk

include bsd.default-versions.mk in bsd.port.mk and remove all other inclusions.
ClosedPublic
Actions

Revision Contents
Changeset List