Differential D7349

xen-netfront: fix trying to send packets with disconnected netfront
ClosedPublic
Actions

Authored by royger on Jul 28 2016, 2:12 PM.

Tags

None

Referenced Files

	F151915941: D7349.id18879.diff
	Sat, Apr 11, 12:35 PM

	F151843653: D7349.diff
	Sat, Apr 11, 1:23 AM

	Unknown Object (File)
	Thu, Apr 9, 8:15 PM

	Unknown Object (File)
	Mon, Apr 6, 4:55 PM

	Unknown Object (File)
	Sun, Apr 5, 1:42 PM

	Unknown Object (File)
	Sat, Apr 4, 12:59 PM

	Unknown Object (File)
	Sun, Mar 22, 7:32 AM

	Unknown Object (File)
	Sun, Mar 22, 3:17 AM

Subscribers

Details

Reviewers

Commits

rS303488: xen-netfront: fix trying to send packets with disconnected netfront

Summary

In certain circumstances xn_txq_mq_start might be called with num_queues ==
0 during the resume phase after a migration, which can trigger a KASSERT.
Fix this by making sure the carrier is on before trying to transmit, or else
return that the queues are full.

Just as a note, I haven't been able to reproduce this crash on my test
systems, but I still think it's possible and worth fixing.

Reported by: Karl Pielorz <kpielorz_lst@tdx.co.uk>
Sponsored by: Citrix Systems R&D
MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

royger updated this revision to Diff 18846.Jul 28 2016, 2:12 PM

royger retitled this revision from to xen-netfront: fix trying to send packets with disconnected netfront.

royger updated this object.

royger edited the test plan for this revision. (Show Details)

royger added a reviewer: liuw_liuw.name.

Herald added a subscriber: imp. · View Herald TranscriptJul 28 2016, 2:12 PM

liuw_liuw.name accepted this revision.Jul 28 2016, 2:42 PM

liuw_liuw.name edited edge metadata.

This revision is now accepted and ready to land.Jul 28 2016, 2:42 PM

Closed by commit rS303488: xen-netfront: fix trying to send packets with disconnected netfront (authored by royger). · Explain WhyJul 29 2016, 4:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

xen/

netfront/

3 lines

Diff 18879

head/sys/dev/xen/netfront/netfront.c

Loading...