nvme_da: drop periph lock after updating stats for trim
AcceptedPublic
Actions

Authored by imp on Tue, Sep 29, 10:14 PM.

Tags

None

Referenced Files

	F174212169: D60155.diff
	Thu, Oct 1, 9:55 AM

	F174159470: D60155.id188143.diff
	Thu, Oct 1, 12:43 AM

	Unknown Object (File)
	Wed, Sep 30, 11:31 PM

	Unknown Object (File)
	Wed, Sep 30, 10:19 AM

	Unknown Object (File)
	Wed, Sep 30, 10:16 AM

	Unknown Object (File)
	Wed, Sep 30, 3:44 AM

	Unknown Object (File)
	Wed, Sep 30, 1:08 AM

Subscribers

dab

Details

Reviewers

ali_mashtizadeh.com

Group Reviewers

cam

Summary

When agregating trims, we'd drop the periph lock before updating the
stats with cam_iosched_bio_complete. Instead, we need to drop it after
we've done that.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77508
Build 74391: arc lint + arc unit

Event Timeline

imp created this revision.Tue, Sep 29, 10:14 PM

Herald added a reviewer: cam. · View Herald TranscriptTue, Sep 29, 10:14 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Tue, Sep 29, 10:14 PM

imp added a child revision: D60156: da: Update stats with the periph lock held.

Harbormaster completed remote builds in B77508: Diff 188143.Tue, Sep 29, 10:15 PM

ali_mashtizadeh.com accepted this revision.Wed, Sep 30, 4:29 PM

This revision is now accepted and ready to land.Wed, Sep 30, 4:29 PM

Revision Contents
Changeset List

Path

Size

sys/

cam/

nvme/

nvme_da.c

14 lines

Diff 188143

View Options

nvme_da: drop periph lock after updating stats for trimAcceptedPublicActions