lib/googletest: also use -O0 for internal tests with GCC
ClosedPublic
Actions

Authored by siva on Sep 9 2026, 4:46 PM.

Details

Reviewers

Group Reviewers

Commits

rG73d67bc5545b: lib/googletest: also use -O0 for internal tests with GCC
rGcf509d830547: lib/googletest: also use -O0 for internal tests with GCC
rG243bdaff7585: lib/googletest: also use -O0 for internal tests with GCC

Summary

This fixes the build with gcc 16's aggressive inlining.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76705
Build 73588: arc lint + arc unit

Event Timeline

siva created this revision.Sep 9 2026, 4:46 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 9 2026, 4:47 PM

siva requested review of this revision.Sep 9 2026, 4:47 PM

Harbormaster completed remote builds in B76705: Diff 186284.Sep 9 2026, 4:47 PM

It would be good for me to look at providing some feedback upstream. I'll add this to my TODO list for when I get fully online next week.

This revision is now accepted and ready to land.Sep 12 2026, 1:36 AM

Closed by commit rG243bdaff7585: lib/googletest: also use -O0 for internal tests with GCC (authored by siva). · Explain WhySep 12 2026, 6:30 PM

This revision was automatically updated to reflect the committed changes.

siva added a commit: rG243bdaff7585: lib/googletest: also use -O0 for internal tests with GCC.

siva added a commit: rGcf509d830547: lib/googletest: also use -O0 for internal tests with GCC.Mon, Sep 14, 2:22 PM

siva added a commit: rG73d67bc5545b: lib/googletest: also use -O0 for internal tests with GCC.Mon, Sep 14, 2:48 PM

Revision Contents
Changeset List

Path

Size

lib/

googletest/

tests/

Makefile.inc

6 lines

Diff 186284

View Options

lib/googletest/tests/Makefile.inc

lib/googletest: also use -O0 for internal tests with GCCClosedPublicActions