Page MenuHomeFreeBSD
Differential D59479

Reduce eqos if driver noisiness
AcceptedPublic
Actions

Authored by bscott_bunyatech.com.au on Mon, Sep 7, 11:48 AM.
Tags
Referenced Files
F171224504: D59479.diff
Wed, Sep 9, 3:42 PM
F171216724: D59479.diff
Wed, Sep 9, 2:32 PM
F171215695: D59479.diff
Wed, Sep 9, 2:23 PM
F171169433: D59479.id186121.diff
Wed, Sep 9, 5:06 AM
Unknown Object (File)
Tue, Sep 8, 4:44 PM
Unknown Object (File)
Tue, Sep 8, 11:38 AM
Unknown Object (File)
Tue, Sep 8, 6:04 AM
Unknown Object (File)
Tue, Sep 8, 2:07 AM
Subscribers
imp

Details

Reviewers
mhorne
Group Reviewers
riscv
Summary

Reduce very common console messages:
Receive error rdes3=30208000
Also count errors for netstat purposes

Also, differentiate between overflow errors and others. Still report the errors when the length is non-zero (overflow errors).

Test Plan

Confirm less console messages: Receive error rdes3=*
Confirm that netstat -i shows incrementing error count after a few large transfers (this is assuming these errors are always going to happen).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bscott_bunyatech.com.au created this revision.Mon, Sep 7, 11:48 AM
Herald added a subscriber: imp. · View Herald TranscriptMon, Sep 7, 11:48 AM
bscott_bunyatech.com.au requested review of this revision.Mon, Sep 7, 11:48 AM
mhorne accepted this revision.Wed, Sep 9, 1:56 PM

LGTM.

Note, the eqos(4) driver has an uncertain future. It is possible that we will move to supporting this hardware with the dwc(4) driver instead; see https://reviews.freebsd.org/D59191 if interested.

Of course, this does not block this change, which I will merge right away.

This revision is now accepted and ready to land.Wed, Sep 9, 1:56 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
eqos/
if_eqos.c
if_eqos.c.orig
10 lines

Diff 186121

View Options

sys/dev/eqos/if_eqos.c

Loading...