Differential D59297

ufshci: fix the Snapdragon X Elite reference clock
ClosedPublic
Actions

Authored by jaeyoon on Tue, Sep 1, 6:07 AM.

Tags

None

Referenced Files

	F170081288: D59297.diff
	Thu, Sep 3, 11:14 AM

	F170045654: D59297.id.diff
	Thu, Sep 3, 8:43 AM

	Unknown Object (File)
	Wed, Sep 2, 12:48 PM

	Unknown Object (File)
	Wed, Sep 2, 6:19 AM

	Unknown Object (File)
	Wed, Sep 2, 6:19 AM

	Unknown Object (File)
	Tue, Sep 1, 11:54 PM

	Unknown Object (File)
	Tue, Sep 1, 11:24 AM

	Unknown Object (File)
	Tue, Sep 1, 9:02 AM

View All 9 Files

Subscribers

None

Details

Reviewers

Commits

rG973783515e7d: ufshci: fix the Snapdragon X Elite reference clock

Summary

The driver's ACPI table set bRefClkFreq to 19.2 MHz. The
Snapdragon X Elite feeds the device 38.4 MHz from its CXO. The
firmware has no property for it. The device ran its PLL from
the wrong base. Every HS mode failed. PWM still worked. The
attribute is persistent. The wrong value survived reboots.

Set 38.4 MHz in the table. Read the attribute first. Write it
only when the value differs or the read fails. Log a changed
value and a failed read. Verified on the Galaxy Book 4 Edge.

Sponsored by: Samsung Electronics

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jaeyoon requested review of this revision.Tue, Sep 1, 6:07 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B76368: Diff 185535.Tue, Sep 1, 6:07 AM

jaeyoon added a child revision: D59298: ufshci: set HS series per platform and adapt type per gear.Tue, Sep 1, 6:08 AM

imp accepted this revision.Tue, Sep 1, 10:08 PM

This revision is now accepted and ready to land.Tue, Sep 1, 10:08 PM

Closed by commit rG973783515e7d: ufshci: fix the Snapdragon X Elite reference clock (authored by jaeyoon). · Explain WhyWed, Sep 2, 2:08 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rG973783515e7d: ufshci: fix the Snapdragon X Elite reference clock.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

6 lines

17 lines

Diff 185606

sys/dev/ufshci/ufshci_acpi.c

Loading...

sys/dev/ufshci/ufshci_dev.c

Loading...