ufshci: handle a recovery reset before the SIM attach
ClosedPublic
Actions

Authored by jaeyoon on Wed, Aug 19, 5:43 AM.

Details

Reviewers

Commits

rGe59d4ec66fca: ufshci: handle a recovery reset before the SIM attach

Summary

When the first start attempt fails early, the recovery reset
runs the start sequence again without a SIM. That pass still
looked up the WLUN, so it dereferenced a NULL SIM and panicked.

Attach the SIM whenever it does not exist yet. Also make the
WLUN lookup return NULL when there is no SIM.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jaeyoon requested review of this revision.Wed, Aug 19, 5:43 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75700: Diff 184310.Wed, Aug 19, 5:43 AM

jaeyoon added a parent revision: D58946: ufshci: build valid fake responses for manual completion.Wed, Aug 19, 5:43 AM

jaeyoon added a child revision: D58948: ufshci: reject new requests on a failed controller.Wed, Aug 19, 5:52 AM

imp accepted this revision.Sat, Aug 22, 3:17 PM

This revision is now accepted and ready to land.Sat, Aug 22, 3:17 PM

Closed by commit rGe59d4ec66fca: ufshci: handle a recovery reset before the SIM attach (authored by jaeyoon). · Explain WhyThu, Aug 27, 5:13 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rGe59d4ec66fca: ufshci: handle a recovery reset before the SIM attach.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

ufshci_ctrlr.c

7 lines

ufshci_sim.c

4 lines

Diff 185182

View Options

sys/dev/ufshci/ufshci_ctrlr.c