ufshci: build valid fake responses for manual completion
ClosedPublic
Actions

Authored by jaeyoon on Wed, Aug 19, 5:33 AM.

Details

Reviewers

Commits

rG746278a6ddc8: ufshci: build valid fake responses for manual completion

Summary

The manual completion wrote the fake response to the wrong
descriptor for task management slots. It also left the task tag
at zero, which tripped the task tag check under INVARIANTS.

Write the fake response where the completion path reads it.
Copy the task tag from the request.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jaeyoon requested review of this revision.Wed, Aug 19, 5:33 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75699: Diff 184309.Wed, Aug 19, 5:33 AM

jaeyoon added a parent revision: D58945: ufshci: claim trackers before failing them.Wed, Aug 19, 5:34 AM

jaeyoon added a child revision: D58947: ufshci: handle a recovery reset before the SIM attach.Wed, Aug 19, 5:43 AM

imp accepted this revision.Sat, Aug 22, 3:16 PM

This revision is now accepted and ready to land.Sat, Aug 22, 3:16 PM

Closed by commit rG746278a6ddc8: ufshci: build valid fake responses for manual completion (authored by jaeyoon). · Explain WhyThu, Aug 27, 5:13 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rG746278a6ddc8: ufshci: build valid fake responses for manual completion.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

ufshci_req_queue.c

26 lines

Diff 185179

View Options

sys/dev/ufshci/ufshci_req_queue.c

ufshci: build valid fake responses for manual completionClosedPublicActions