ufshci: claim trackers before failing them
ClosedPublic
Actions

Authored by jaeyoon on Wed, Aug 19, 5:31 AM.

Details

Reviewers

Commits

rG7682b8f37669: ufshci: claim trackers before failing them

Summary

ufshci_req_queue_fail() drops the queue lock to complete each
tracker. In that window the completion path could complete the
same tracker again.

Claim the slot before dropping the lock, so the completion scan
skips it. Reserved slots are left to their submit thread, which
completes them itself. The manual request completion helper
lost its only caller, so drop it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75698
Build 72581: arc lint + arc unit

Event Timeline

jaeyoon requested review of this revision.Wed, Aug 19, 5:31 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75698: Diff 184308.Wed, Aug 19, 5:32 AM

jaeyoon added a parent revision: D58944: ufshci: run the controller fail path only once.Wed, Aug 19, 5:32 AM

jaeyoon added a child revision: D58946: ufshci: build valid fake responses for manual completion.

imp accepted this revision.Sat, Aug 22, 3:16 PM

This revision is now accepted and ready to land.Sat, Aug 22, 3:16 PM

Closed by commit rG7682b8f37669: ufshci: claim trackers before failing them (authored by jaeyoon). · Explain WhyThu, Aug 27, 5:13 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rG7682b8f37669: ufshci: claim trackers before failing them.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

ufshci_req_queue.c

60 lines

Diff 184308

View Options

sys/dev/ufshci/ufshci_req_queue.c

ufshci: claim trackers before failing themClosedPublicActions