Differential D58944

ufshci: run the controller fail path only once
ClosedPublic
Actions

Authored by jaeyoon on Aug 19 2026, 5:31 AM.

Tags

None

Referenced Files

	F175983295: D58944.id185180.diff
	Thu, Oct 15, 12:42 AM

	Unknown Object (File)
	Wed, Oct 14, 1:02 PM

	Unknown Object (File)
	Tue, Oct 13, 8:43 PM

	Unknown Object (File)
	Tue, Oct 13, 2:25 PM

	Unknown Object (File)
	Mon, Oct 12, 6:23 PM

	Unknown Object (File)
	Mon, Oct 12, 10:31 AM

	Unknown Object (File)
	Mon, Oct 12, 7:48 AM

	Unknown Object (File)
	Tue, Oct 6, 6:48 PM

View All 77 Files

Subscribers

None

Details

Reviewers

Commits

rG94e28f979a84: ufshci: run the controller fail path only once
rG1258ae2bcb55: ufshci: run the controller fail path only once

Summary

Two threads could run ufshci_ctrlr_fail() at the same time.
Each one walked the queues and completed the same trackers
again, which caused a double free and a panic.

Turn is_failed into an atomic gate, so only the first caller
walks the queues. The reset task now returns early on a failed
controller instead of re-enabling it.

Sponsored by: Samsung Electronics

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75697
Build 72580: arc lint + arc unit

Event Timeline

jaeyoon requested review of this revision.Aug 19 2026, 5:31 AM

jaeyoon created this revision.

Harbormaster completed remote builds in B75697: Diff 184307.Aug 19 2026, 5:31 AM

jaeyoon added a child revision: D58945: ufshci: claim trackers before failing them.Aug 19 2026, 5:32 AM

imp accepted this revision.Aug 22 2026, 3:15 PM

This revision is now accepted and ready to land.Aug 22 2026, 3:15 PM

Closed by commit rG1258ae2bcb55: ufshci: run the controller fail path only once (authored by jaeyoon). · Explain WhyAug 27 2026, 5:13 AM

This revision was automatically updated to reflect the committed changes.

jaeyoon added a commit: rG1258ae2bcb55: ufshci: run the controller fail path only once.

jaeyoon added a commit: rG94e28f979a84: ufshci: run the controller fail path only once.Tue, Oct 6, 7:54 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ufshci/

12 lines

ufshci_private.h

2 lines

Diff 184307

sys/dev/ufshci/ufshci_ctrlr.c

Loading...

sys/dev/ufshci/ufshci_private.h

Loading...