3.10.45, take maintainership
ClosedPublic
Actions

Authored by alven on Sun, Aug 16, 12:41 PM.

Details

Reviewers

danilo

Commits

R11:3855ba229166: cad/xcircuit: Update 3.10.44 => 3.10.45, take maintainership

Summary

Add WWW for source code repository

Test Plan

For every {151amd64, 144amd64}:

Successful poudriere testport
Successful run-testing

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 75624
Build 72507: arc lint + arc unit

Event Timeline

alven requested review of this revision.Sun, Aug 16, 12:41 PM

alven created this revision.

Harbormaster completed remote builds in B75619: Diff 184125.Sun, Aug 16, 12:41 PM

Hi, thanks for your patch. My only comment is about moving from USE_GITHUB back to MASTER_SITES (see inline).

Also, do you want to take maintainership of this port? If so, feel free to update the MAINTAINER field too :)

Thanks

cad/xcircuit/Makefile
5	Any good reason to revert back to MASTER_SITES? Looks like an unnecessary change, I think.

This revision now requires changes to proceed.Sun, Aug 16, 1:11 PM

In D58866#1350950, @danilo wrote:

Hi, thanks for your patch. My only comment is about moving from USE_GITHUB back to MASTER_SITES (see inline).

Hi! I wouldn't insist on it, would it not to your like. I was just for static tarball, as preferred by handbook, from official site, as preferred by me :)

Also, do you want to take maintainership of this port? If so, feel free to update the MAINTAINER field too :)

Thanks

Yes, I would like to! :)
Thank you

Harbormaster completed remote builds in B75624: Diff 184134.Sun, Aug 16, 6:35 PM

alven retitled this revision from cad/xcircuit: Update 3.10.44 => 3.10.45 to cad/xcircuit: Update 3.10.44 => 3.10.45, take maintainership.Sun, Aug 16, 6:37 PM

alven edited the summary of this revision. (Show Details)

Thank you :)

This revision is now accepted and ready to land.Sun, Aug 16, 8:54 PM

Closed by commit R11:3855ba229166: cad/xcircuit: Update 3.10.44 => 3.10.45, take maintainership (authored by alven). · Explain WhySun, Aug 16, 10:41 PM

This revision was automatically updated to reflect the committed changes.

alven added a commit: R11:3855ba229166: cad/xcircuit: Update 3.10.44 => 3.10.45, take maintainership.