Page MenuHomeFreeBSD
Differential D58848

devel/py-pyyaml: Convert build to use PEP 517
ClosedPublic
Actions

Authored by michaelo on Fri, Aug 14, 10:09 PM.
Tags
None
Referenced Files
F167738681: D58848.id184794.diff
Mon, Aug 24, 4:27 AM
F167737970: D58848.id184089.diff
Mon, Aug 24, 4:17 AM
F167732254: D58848.id184794.diff
Mon, Aug 24, 2:57 AM
F167730330: D58848.id.diff
Mon, Aug 24, 2:32 AM
F167699750: D58848.diff
Sun, Aug 23, 8:46 PM
F167667604: D58848.id184748.diff
Sun, Aug 23, 4:25 PM
F167667561: D58848.id184794.diff
Sun, Aug 23, 4:24 PM
Unknown Object (File)
Sun, Aug 16, 4:27 AM
View All 10 Files
Subscribers
None

Details

Reviewers
vishwin
mandree
diizzy
Group Reviewers
Python
Commits
R11:7085414bb689: devel/py-pyyaml: Convert build to use PEP 517

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75595
Build 72478: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Fri, Aug 14, 10:09 PM
michaelo created this revision.
Harbormaster completed remote builds in B75595: Diff 184077.Fri, Aug 14, 10:09 PM
michaelo added a reviewer: Python.Fri, Aug 14, 10:09 PM
vishwin requested changes to this revision.Fri, Aug 14, 10:36 PM
vishwin added inline comments.
devel/py-pyyaml/Makefile
42

Under no circumstances is this to be overridden. The framework does not even have this ability and one will never be added.

When setuptools is updated past 70.1, ie D46236, it will be normalised to all lowercase anyway. For now, patch setup.py.

44

This whole block is excessive.

This revision now requires changes to proceed.Fri, Aug 14, 10:36 PM
michaelo updated this revision to Diff 184089.Sat, Aug 15, 8:38 AM

Address comments and lowercase wheel name in setup.py

Harbormaster completed remote builds in B75605: Diff 184089.Sat, Aug 15, 8:39 AM
michaelo marked 2 inline comments as done.Sat, Aug 15, 8:39 AM

Changes applied.

michaelo added a comment.Sat, Aug 15, 11:27 AM

@vishwin This should be good now, take another look please.

michaelo updated this revision to Diff 184748.Sat, Aug 22, 9:30 PM

Rebase

Harbormaster completed remote builds in B75969: Diff 184748.Sat, Aug 22, 9:30 PM
vishwin added inline comments.Sun, Aug 23, 3:14 PM
devel/py-pyyaml/Makefile
26

Why is this block here under options/conditional processing instead of the regular location, and +=?

michaelo updated this revision to Diff 184793.Sun, Aug 23, 3:33 PM

A leftover from previous code, changed and tested

Harbormaster completed remote builds in B75984: Diff 184793.Sun, Aug 23, 3:33 PM
michaelo added inline comments.Sun, Aug 23, 3:36 PM
devel/py-pyyaml/Makefile
26

Not 100% sure whether python.mk presets it. If safe to assign only, I am fine.

michaelo updated this revision to Diff 184794.Sun, Aug 23, 3:40 PM

Replace += with =

Harbormaster completed remote builds in B75985: Diff 184794.Sun, Aug 23, 3:40 PM
michaelo added a comment.Sun, Aug 23, 3:53 PM

@vishwin, is this as expected now?

vishwin added inline comments.Sun, Aug 23, 4:02 PM
devel/py-pyyaml/Makefile
26

Never preset. The build backend that will be used must always be explicitly declared in BUILD_DEPENDS under USE_PYTHON=pep517.

This block is still in the wrong location, especially when unconditional.

michaelo updated this revision to Diff 184796.Sun, Aug 23, 4:23 PM

Sort for portclippy

Harbormaster completed remote builds in B75987: Diff 184796.Sun, Aug 23, 4:23 PM
vishwin accepted this revision.Sun, Aug 23, 6:34 PM
This revision is now accepted and ready to land.Sun, Aug 23, 6:34 PM
Closed by commit R11:7085414bb689: devel/py-pyyaml: Convert build to use PEP 517 (authored by michaelo). · Explain WhySun, Aug 23, 8:04 PM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: R11:7085414bb689: devel/py-pyyaml: Convert build to use PEP 517.

Revision Contents
Changeset List

PathSize
devel/
py-pyyaml/
49 lines

Diff 184077

View Options

devel/py-pyyaml/Makefile

Loading...