bsd.gcc.mk: add static keyword for USE_GCC
AbandonedPublic
Actions

Authored by novel on Jul 10 2016, 11:14 PM.

Details

Reviewers

Summary

A proof of concept patch that adds "static" keyword for USE_GCC. With that keyword specified, gcc is not pulled as a dependency because statically linked code does not need it.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

novel updated this revision to Diff 18255.Jul 10 2016, 11:14 PM

novel retitled this revision from to bsd.gcc.mk: add static keyword for USE_GCC.

novel updated this object.

novel edited the test plan for this revision. (Show Details)

novel added a reviewer: gerald.

novel set the repository for this revision to rP FreeBSD ports repository.

Herald added a subscriber: mat. · View Herald TranscriptJul 10 2016, 11:14 PM

I wonder if it's better to stay with :build as the argument name so it's consistent with other USES/USE_* bits, all of which don't expose implementation details in their naming, instead just defined by the 'dependency type'.

I think it's easier/more obvious for people (porters/maintainers) to know that GCC is just a build only dependency, rather than something being statically linked

koobs updated this object.Jul 17 2016, 8:42 AM

Yeah, it should be :build to be consistent.

I'm abandoning this review, please look at the better patch that's doing the same thing: https://reviews.freebsd.org/D7223

Revision Contents
Changeset List

Path

Size

	bsd.gcc.mk
	bsd.gcc.mk.orig

12 lines

Diff 18255

View Options

bsd.gcc.mk: add static keyword for USE_GCCAbandonedPublicActions