sysutils/rdfind: add support for xxhash
ClosedPublic
Actions

Authored by skozlov on Wed, Jul 22, 5:31 PM.

Details

Reviewers

dtxdf

Commits

R11:a4214f1e3bed: sysutils/rdfind: add support for xxhash

Summary

In the current form - the support for xxhash depends on whether or not
xxhash is installed in the system where the port is built. See
https://github.com/pauldreik/rdfind#development.

This commit makes (lack of) support for xxhash explicit. If the option
is enabled - the xxhash is added to dependencies and built into rdfind,
if disabled - xxhash support is disabled even if the library is present
in the system.

For the sake of not changing the default behavior - the xxhash support
is disabled by default.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75018
Build 71901: arc lint + arc unit

Event Timeline

skozlov requested review of this revision.Wed, Jul 22, 5:31 PM

skozlov created this revision.

Harbormaster completed remote builds in B75018: Diff 182471.Wed, Jul 22, 5:31 PM

Thank you for this.

I don't think there's any problem with enabling XXHASH by default, since it's a lightweight dependency.

Make XXHASH option default

Harbormaster completed remote builds in B75036: Diff 182521.Thu, Jul 23, 10:44 AM

In D58398#1339775, @dtxdf wrote:

Thank you for this.

I don't think there's any problem with enabling XXHASH by default, since it's a lightweight dependency.

Done. If you like it - please accept and I'm going to land it :)

dtxdf accepted this revision.Thu, Jul 23, 2:52 PM

This revision is now accepted and ready to land.Thu, Jul 23, 2:52 PM

Closed by commit R11:a4214f1e3bed: sysutils/rdfind: add support for xxhash (authored by skozlov). · Explain WhyWed, Jul 29, 10:13 AM

This revision was automatically updated to reflect the committed changes.

skozlov added a commit: R11:a4214f1e3bed: sysutils/rdfind: add support for xxhash.