Page MenuHomeFreeBSD

sysutils/rdfind: add support for xxhash
AcceptedPublic

Authored by skozlov on Wed, Jul 22, 5:31 PM.
Tags
None
Referenced Files
F163797379: D58398.id182471.diff
Sun, Jul 26, 3:14 AM
F163752917: D58398.id182471.diff
Sat, Jul 25, 8:17 PM
Unknown Object (File)
Fri, Jul 24, 9:28 PM
Unknown Object (File)
Wed, Jul 22, 5:55 PM
Subscribers
None

Details

Reviewers
dtxdf
Summary

In the current form - the support for xxhash depends on whether or not
xxhash is installed in the system where the port is built. See
https://github.com/pauldreik/rdfind#development.

This commit makes (lack of) support for xxhash explicit. If the option
is enabled - the xxhash is added to dependencies and built into rdfind,
if disabled - xxhash support is disabled even if the library is present
in the system.

For the sake of not changing the default behavior - the xxhash support
is disabled by default.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75036
Build 71919: arc lint + arc unit

Event Timeline

skozlov created this revision.

Thank you for this.

I don't think there's any problem with enabling XXHASH by default, since it's a lightweight dependency.

Thank you for this.

I don't think there's any problem with enabling XXHASH by default, since it's a lightweight dependency.

Done. If you like it - please accept and I'm going to land it :)

This revision is now accepted and ready to land.Thu, Jul 23, 2:52 PM