Page MenuHomeFreeBSD
Differential D58120

devel/jansson: Fix symbol versioning
ClosedPublic
Actions

Authored by des on Thu, Jul 9, 8:01 AM.
Tags
None
Referenced Files
F162915686: D58120.id181589.diff
Sat, Jul 18, 6:47 AM
F162907835: D58120.id181768.diff
Sat, Jul 18, 4:58 AM
Unknown Object (File)
Sat, Jul 18, 2:00 AM
Unknown Object (File)
Sat, Jul 18, 12:33 AM
Unknown Object (File)
Sat, Jul 18, 12:27 AM
Unknown Object (File)
Fri, Jul 17, 10:50 PM
Unknown Object (File)
Fri, Jul 17, 9:16 PM
Unknown Object (File)
Fri, Jul 17, 9:15 PM
View All 27 Files
Subscribers
None

Details

Reviewers
vanilla
diizzy
Commits
R11:3694a9a7f775: devel/jansson: Fix symbol versioning
R11:29783922a860: devel/jansson: Fix symbol versioning
Summary

MFH: 2026Q3

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74692
Build 71575: arc lint + arc unit

Event Timeline

des requested review of this revision.Thu, Jul 9, 8:01 AM
des created this revision.
Harbormaster completed remote builds in B74644: Diff 181589.Thu, Jul 9, 8:01 AM
des edited the summary of this revision. (Show Details)Thu, Jul 9, 8:04 AM
diizzy added a comment.Thu, Jul 9, 5:19 PM

Nice, good catch! For easier tracking I'd suggest that we pull this from GitHub rather than adding it to the tree.

jansson-PR750.patch1 KBDownload

des updated this revision to Diff 181682.Fri, Jul 10, 8:03 AM

use upstream patch

Harbormaster completed remote builds in B74692: Diff 181682.Fri, Jul 10, 8:03 AM
diizzy added a comment.Fri, Jul 10, 10:29 AM

distinfo updates are missing, LGTM

des updated this revision to Diff 181692.Fri, Jul 10, 11:17 AM

makesum

Harbormaster completed remote builds in B74699: Diff 181692.Fri, Jul 10, 11:17 AM
des added a comment.Fri, Jul 10, 11:18 AM

ping @vanilla

diizzy added a comment.Sat, Jul 11, 6:29 AM

Two issues with using Phab is that Porters Handbook's time outs don't apply to it and you don't necessarily even as a registered user receive emails. However, since there were a PR earlier (and emails have been sent) and upstream applied this PR just merge it as a build-fix.

des added a comment.Sat, Jul 11, 7:02 AM
In D58120#1333936, @diizzy wrote:

Two issues with using Phab is that Porters Handbook's time outs don't apply to it and you don't necessarily even as a registered user receive emails. However, since there were a PR earlier (and emails have been sent) and upstream applied this PR just merge it as a build-fix.

Right, there was no need to close the ticket, Bugzilla and Phabricator are complementary, not competing.

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Jul 11, 12:49 PM
Closed by commit R11:29783922a860: devel/jansson: Fix symbol versioning (authored by des). · Explain Why
This revision was automatically updated to reflect the committed changes.
des added a commit: R11:29783922a860: devel/jansson: Fix symbol versioning.
des added a commit: R11:3694a9a7f775: devel/jansson: Fix symbol versioning.

Revision Contents
Changeset List

PathSize
devel/
jansson/
5 lines

Diff 181682

View Options

devel/jansson/Makefile

Loading...