Page MenuHomeFreeBSD

Harmonize the cross repo advice.
ClosedPublic

Authored by imp on Thu, Jul 2, 4:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 11, 5:46 AM
Unknown Object (File)
Thu, Jul 9, 10:50 PM
Unknown Object (File)
Thu, Jul 9, 6:09 PM
Unknown Object (File)
Thu, Jul 9, 6:05 PM
Unknown Object (File)
Thu, Jul 9, 11:03 AM
Unknown Object (File)
Thu, Jul 9, 6:15 AM
Unknown Object (File)
Wed, Jul 8, 9:43 AM
Unknown Object (File)
Tue, Jul 7, 7:43 PM
Subscribers
None

Details

Summary

The other committer's guide was written years before the cross repo
commit bit stuff. Harmonize and expand a little the advice given to make
it also match the tone of the new policy and our usual practices being a
little more relaxed than what was documented previously.

Sponsored by: Netflix

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74484
Build 71367: arc lint + arc unit

Event Timeline

imp requested review of this revision.Thu, Jul 2, 4:36 PM
imp created this revision.
documentation/content/en/articles/committers-guide/_index.adoc
272

I wonder if we want to relax this to "All committers" vs just Doc? I'm fine with keeping the existing language though.

2645

I really want this case to just be "Reviewed by;" and not "Approved by:". That is, the point is to get review of the change itself not permission to commit a change separate from reviewing it.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jul 14, 11:01 PM
This revision was automatically updated to reflect the committed changes.