net/rsync: Add back the FLAGS option
Needs ReviewPublic
Actions

Authored by des on Thu, Jun 18, 2:19 PM.

Details

Reviewers

Summary

This restores support for copying file flags and fixes a long-standing
peeve of mine by renaming the command-line option to --file-flags,
better matching the naming style of other rsync options. Full backward
compatibility is maintained, including with older servers.

MFH: 2026Q2

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74053
Build 70936: arc lint + arc unit

Event Timeline

des requested review of this revision.Thu, Jun 18, 2:19 PM

des created this revision.

Harbormaster completed remote builds in B73975: Diff 179993.Thu, Jun 18, 2:19 PM

fix refuse_match

Harbormaster completed remote builds in B73984: Diff 180015.Thu, Jun 18, 7:57 PM

last remnant of PTS

Harbormaster completed remote builds in B73986: Diff 180017.Thu, Jun 18, 8:02 PM

rodrigo added inline comments.Sat, Jun 20, 8:27 AM

net/rsync/files/extra-patch-file-flags.diff
487	--force switch still exists and has the same effect of --force-delete so its description in the manpage should be : --force an alias for --force-delete

--force

Harbormaster completed remote builds in B74053: Diff 180153.Sat, Jun 20, 1:03 PM

Since this patch is larger than a simple porting patch, and given that it is intended to evolve in the near future,
it probably easier to keep it in a separate VCS system to help track evolution and changes.

If you don't mind I can create a separate GH repo for this additional patch, so I don't have to involve yourself
at any rsync update who break things.
BTW, I'm open to other alternatives too.

net/rsync/files/extra-patch-file-flags.diff
478	--fileflags switch was kept in the command line options, which is good to prevent POLA breakage but we should also keep it in the manpage to avoid users confusion: --fileflags an alias for --file-flags

In D57645#1323366, @rodrigo wrote:

Since this patch is larger than a simple porting patch, and given that it is intended to evolve in the near future,
it probably easier to keep it in a separate VCS system to help track evolution and changes.

https://github.com/dag-erling/rsync/tree/des/file-flags