Page MenuHomeFreeBSD

update version to 9.0.18
ClosedPublic

Authored by d.stoye_cms.hu-berlin.de on Tue, Jun 16, 7:03 PM.
Tags
None
Referenced Files
F160218745: D57610.id179910.diff
Mon, Jun 22, 7:17 AM
F160170183: D57610.id179973.diff
Sun, Jun 21, 9:24 PM
F160165390: D57610.diff
Sun, Jun 21, 8:45 PM
F160158741: D57610.id180003.diff
Sun, Jun 21, 8:13 PM
Unknown Object (File)
Sat, Jun 20, 11:14 PM
Unknown Object (File)
Sat, Jun 20, 11:14 PM
Unknown Object (File)
Sat, Jun 20, 10:51 PM
Unknown Object (File)
Sat, Jun 20, 10:41 PM
Subscribers

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 73957
Build 70840: arc lint + arc unit

Event Timeline

Any chance to upstream your inline patches?

Any chance to upstream your inline patches?

Yes, i'm planning on doing that. As seafile is currently unbuildable without patches on FreeBSD.

Can you fix metadata on your patch while I am running in poudriere: Author: Charlie Root <root@bsdell.fritz.box>?

update metadata

Great, running poudriere now...

GUI does not configure for me, qmake is missing:

===>  Configuring for seafile-gui-9.0.18_1
===>  Performing out-of-source build
/bin/mkdir -p /wrkdirs/usr/ports/net-mgmt/seafile-gui/work/.build
CMake Deprecation Warning at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


-- The C compiler identification is Clang 19.1.7
-- The CXX compiler identification is Clang 19.1.7
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/local/bin/pkgconf (found version "2.4.3")
CMake Warning (dev) at CMakeLists.txt:37 (SET):
  implicitly converting 'Path to breakpad's root' to 'STRING' type.
This warning is for project developers.  Use -Wno-dev to suppress it.

Build type: Release
bash: line 1: qmake_executable-NOTFOUND: command not found
Qt version:
bash: line 1: qmake: command not found
QT_VERSION_MAJOR:
CMake Error at /usr/local/lib/cmake/Qt5/Qt5Config.cmake:28 (find_package):
  Could not find a package configuration file provided by "Qt5WebEngineCore"
  with any of the following names:

    Qt5WebEngineCoreConfig.cmake
    qt5webenginecore-config.cmake

  Add the installation prefix of "Qt5WebEngineCore" to CMAKE_PREFIX_PATH or
  set "Qt5WebEngineCore_DIR" to a directory containing one of the above
  files.  If "Qt5WebEngineCore" provides a separate development package or
  SDK, be sure it has been installed.
Call Stack (most recent call first):
  CMakeLists.txt:181 (FIND_PACKAGE)


-- Configuring incomplete, errors occurred!
*** Error code 1

i am setting up a clean build environment, to not miss any more dependencies, will update Makefile afterwards

GUI does not configure for me, qmake is missing:

not qmake, but webengine (USE_QT= webengine). Please, consider switching the port to Qt 6, since Qt 5 is EOLed. You may need to use CMAKE_ARGS= -DQT_VERSION_MAJOR=6 for that.

Make Q/A is unsure:

Error: /usr/local/bin/seafile-applet is linked to /usr/local/lib/qt5/libQt5Positioning.so.5 from devel/qt5-location but it is not declared as a dependency
Warning: you need USES=qt:5 and USE_QT+=location

vs:

Warning: you might not need LIB_DEPENDS on libQt5Location.so

So i'll keep it for now.

GUI does not configure for me, qmake is missing:

not qmake, but webengine (USE_QT= webengine). Please, consider switching the port to Qt 6, since Qt 5 is EOLed. You may need to use CMAKE_ARGS= -DQT_VERSION_MAJOR=6 for that.

when these 2 packages are building now, is that something i can do in _2? so we have a current version for now?
Or is it a blocker?

Or is it a blocker?

No, it's not a blocker. Use can still use Qt5 if you need to update to the latest version as soon as possible, and switch to Qt 6 later.

To switch the port to Qt6 replace USES= qt:5 with USES= qt:6 and adjust USE_QT components. If cmake checks for Qt5 first, then pass CMAKE_ARGS= -DQT_VERSION_MAJOR=6 to force the build with Qt 6.

net-mgmt/seafile-gui/files/patch-CMakeLists.txt
19 ↗(On Diff #180003)

This whole block is not needed, QT_VERSION_MAJOR is already set via CMAKE_ARGS. I'd remove these calls to bash and qmake at all, they are useless.

CMake looks for required Qt components at https://github.com/haiwen/seafile-client/blob/eb750ba84d834082679ed4aeec2e1f0bd6d97a62/CMakeLists.txt#L179 and it will find them without bash/qmake.

remove useless QT-Version check from CMakeLists.txt

net-mgmt/seafile-gui/Makefile
20

Not needed, USE_GL= opengl already pulls graphics/libglvnd.

32

trailing whitespace. You can use ports-mgmt/portlint to check your ports.

40

DEBUG should never be a option, ports should check for WITH_DEBUG [1] if needed. And NLS is no-op for this port, so it should be removed along with unused gettext dependency.

[1] https://docs.freebsd.org/en/books/porters-handbook/book/#testing-debugging-ports

d.stoye_cms.hu-berlin.de marked 4 inline comments as done.

added feedback by makc
used make makepatch instead of diff -u
fixed portlint warnings

This revision is now accepted and ready to land.Fri, Jun 19, 4:29 PM

I am still waiting for qt6-webengine-6.11.1 to complete...

Builds for me as well. Will commit to main.