Page MenuHomeFreeBSD
Differential D56334

devel/gumbo: Update to 0.13.2
Needs ReviewPublic
Actions

Authored by dave_freedave.net on Thu, Apr 9, 5:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 18, 9:41 AM
Unknown Object (File)
Sat, Apr 18, 9:41 AM
Unknown Object (File)
Sat, Apr 18, 9:41 AM
Unknown Object (File)
Sat, Apr 18, 9:41 AM
Unknown Object (File)
Sat, Apr 18, 9:41 AM
Unknown Object (File)
Sat, Apr 18, 9:41 AM
Unknown Object (File)
Sat, Apr 18, 7:49 AM
Unknown Object (File)
Thu, Apr 16, 7:16 AM
View All 13 Files
Subscribers
diizzy

Details

Reviewers
bdrewery
Summary

0.13.1 switched to meson and 0.13.2 added fuzzing tests.
Neither altered ABI/API

I am interested in creating some language bindings to gumbo and wanted to make sure that the latest still works with FreeBSD. Since everything worked out, may as well make available.

Test Plan

make test succeeds

poudriere testport -j FreeBSD16 -p local devel/gumbo:

gumbo-0.13.2.log30 KBDownload

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dave_freedave.net requested review of this revision.Thu, Apr 9, 5:46 PM
dave_freedave.net created this revision.
dave_freedave.net attached a referenced file: F151642387: gumbo-0.13.2.log. (Show Details)
dave_freedave.net updated this revision to Diff 175193.Thu, Apr 9, 7:11 PM

https://codeberg.org/grisha/gumbo-parser has moved to https://codeberg.org/gumbo-parser/gumbo-parser

see README

diizzy added a subscriber: diizzy.Sun, Apr 12, 8:55 AM
diizzy added inline comments.
devel/gumbo/Makefile
12

Tests should be built on demand

13

Missing c++17-lang definition
https://cgit.freebsd.org/ports/tree/Mk/Uses/compiler.mk

17

This is incorrect

19

Why?
Set WRKSRC correctly if needed

22

Likely unnecessary

dave_freedave.net updated this revision to Diff 175351.Sun, Apr 12, 2:55 PM

address comments:

  • change BUILD_DEPENDS to TEST_DEPENDS for googletest>0:devel/googletest
  • add compiler:c++17-lang to USES
  • remvove INSTALL_TARGET (had no effect)
  • remove post-extract target, just adjust WRKSRC
  • add MESON_ARGS until upstream fixes gtest detection with note on how to test
  • remove post-install target (also no effect)
dave_freedave.net marked 5 inline comments as done.Sun, Apr 12, 2:56 PM

Revision Contents
Changeset List

PathSize
devel/
gumbo/
11 lines
6 lines

Diff 175193

View Options

devel/gumbo/Makefile

Loading...
View Options

devel/gumbo/distinfo

Loading...