Page MenuHomeFreeBSD

filesystems/gvfs: Add option to use fuser(1) in place of lsof(1)
Needs ReviewPublic

Authored by madpilot on Thu, Apr 2, 4:32 PM.
Tags
None
Referenced Files
F151289426: D56224.diff
Tue, Apr 7, 8:49 AM
Unknown Object (File)
Fri, Apr 3, 4:47 PM
Subscribers

Details

Reviewers
None
Group Reviewers
gnome
Summary

gvfs has an hard dependency on lsof(1), due to the code using it in just one place to lookup PIDS for programs preventing a removable disk unmount.

lsof(1) is a problematic port, often breaking on head. furthermore, gvfs is depended upon by many desktop environments and programs, causing lsoif to be nstalled on many machines, for just this single internal usage scenario.

We do have fuser(1) in base that provides the required functionality. This patch, also submitted upstream [1] allows us to shed this hard dependency, und use fuser(1) to get the list of pids.

I think this would be a big improvement for many users.

[1] https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/321

Test Plan

I'm running this patch with XFCE and everything looks fine. Maybe some testing by toher DE users could be useful.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 71917
Build 68800: arc lint + arc unit

Event Timeline

madpilot created this revision.

Guido, thanks a lot for working on that!