Differential D6755

Don't leak olinep if malloc() fails
ClosedPublic
Actions

Authored by truckman on Jun 8 2016, 8:25 AM.

Details

Reviewers

kib

Commits

rS301921: MFC r301596
rS301596: Don't leak olinep if malloc() fails.

Summary

If malloc() fails to allocate linep, then free olinep if
it exists before returning to avoid a memory leak.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4145
Build 4188: arc lint + arc unit

Event Timeline

truckman updated this revision to Diff 17399.Jun 8 2016, 8:25 AM

truckman retitled this revision from to Don't leak olinep if malloc() fails.

truckman updated this object.

truckman edited the test plan for this revision. (Show Details)

truckman added a reviewer: kib.

Herald added a subscriber: imp. · View Herald TranscriptJun 8 2016, 8:25 AM

kib accepted this revision.Jun 8 2016, 10:19 AM

kib edited edge metadata.

This revision is now accepted and ready to land.Jun 8 2016, 10:19 AM

Closed by commit rS301596: Don't leak olinep if malloc() fails. (authored by truckman). · Explain WhyJun 8 2016, 10:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

getnetgrent.c

2 lines

Diff 17399

View Options

lib/libc/gen/getnetgrent.c

Show First 20 Lines • Show All 608 Lines • ▼ Show 20 Lines	if (pos != '\n' && pos != '\0') {
cont = 1;		cont = 1;
} else		} else
cont = 0;		cont = 0;
if (len > 0) {		if (len > 0) {
linep = malloc(olen + len + 1);		linep = malloc(olen + len + 1);
if (linep == NULL) {		if (linep == NULL) {
free(lp->l_groupname);		free(lp->l_groupname);
free(lp);		free(lp);
		if (olen > 0)
		free(olinep);
return (NULL);		return (NULL);
}		}
if (olen > 0) {		if (olen > 0) {
bcopy(olinep, linep, olen);		bcopy(olinep, linep, olen);
free(olinep);		free(olinep);
}		}
bcopy(pos, linep + olen, len);		bcopy(pos, linep + olen, len);
olen += len;		olen += len;
Show All 34 Lines

Don't leak olinep if malloc() failsClosedPublicActions