Page MenuHomeFreeBSD

LinuxKPI wlan drivers: update makefiles to not use WITH_
Needs ReviewPublic

Authored by bz on Fri, Mar 20, 12:30 AM.
Tags
None
Referenced Files
F149347284: D55977.diff
Mon, Mar 23, 9:56 PM
F149232978: D55977.diff
Mon, Mar 23, 4:40 AM
Unknown Object (File)
Sun, Mar 22, 3:50 PM
Subscribers
None

Details

Reviewers
imp
Summary

Up to now the LinuxKPI wlan drivers were using local variables starting
with a WITH_ prefix. That is likely to collide with other mechanisms
like WITH_ and WITHOUT_ from src.conf. Adjust the local variables to
use a driver name prefix for now to control what is built and what is
not. These variables are mainly for the time of development so we can
turn off/on a feature or bus attachment while working on it. Otherwise
they are there for documentation purposes. The only reason one would
change them locally would be if someone was to build a very custom
image and not want certain bits (e.g., USB support) being compiled into
the modules.

While here, try to harmonize some parts of the Makefiles.

Suggested by: imp
Discussed with: imp
Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71561
Build 68444: arc lint + arc unit

Event Timeline

bz requested review of this revision.Fri, Mar 20, 12:30 AM
bz created this revision.

@imp this is mostly just to glance at if you think the names like this would be fine.

There is a lot more churn in it given I tried to have them all have the same order, comments, ... and I felt like re-doing it and splitting it up into two or more changes would be .. unnecessary unless someone thought differently.

You don't have to Accept the review; I'll be happy with just a comment of "looks okay" or similar...