Page MenuHomeFreeBSD
Differential D55962

devel/ghpr: add missing `BUILD_DEPENDS`
ClosedPublic
Actions

Authored by ngie on Thu, Mar 19, 5:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 31, 8:52 AM
Unknown Object (File)
Mon, Mar 30, 6:33 PM
Unknown Object (File)
Sun, Mar 29, 10:14 PM
Unknown Object (File)
Sun, Mar 29, 2:37 PM
Unknown Object (File)
Sun, Mar 29, 8:42 AM
Unknown Object (File)
Sat, Mar 28, 11:32 PM
Unknown Object (File)
Sat, Mar 28, 8:48 PM
Unknown Object (File)
Sat, Mar 28, 5:32 PM
View All 23 Files
Subscribers
bms
Python

Details

Reviewers
imp
Commits
R11:15c5542e3e7a: devel/ghpr: add missing `BUILD_DEPENDS`
Summary

This change adds additional build dependencies accidentally missed in
the previous commit.

Although the devel/py-setuptools dependency is technically redundant in
light of devel/py-setuptools-scm, it's best to express all of the needed
dependencies in BUILD_DEPENDS.

Adjust PYTHON_USES to only permit 3.11+ given the change introduced in
the pyproject.toml file upstream, while here.

Reported by: poudriere
Pointyhat to: ngie
Fixes: 59337d86174 ("devel/ghpr: update to v3")

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71544
Build 68427: arc lint + arc unit

Event Timeline

ngie requested review of this revision.Thu, Mar 19, 5:38 PM
ngie created this revision.
Harbormaster completed remote builds in B71544: Diff 173941.Thu, Mar 19, 5:38 PM
ngie updated this revision to Diff 173942.Thu, Mar 19, 5:40 PM

Adjust minimum required python version to 3.11 to match pyproject.toml

Harbormaster completed remote builds in B71545: Diff 173942.Thu, Mar 19, 5:40 PM
ngie edited the summary of this revision. (Show Details)Thu, Mar 19, 5:42 PM
ngie added a reviewer: imp.
ngie edited the summary of this revision. (Show Details)
ngie added a subscriber: Python.
ngie added a comment.Sat, Mar 21, 3:36 AM

@imp : ping?

bms added a subscriber: bms.Sun, Mar 22, 3:54 AM
ngie retitled this revision from devel/gphr: add missing `BUILD_DEPENDS` to devel/ghpr: add missing `BUILD_DEPENDS`.Sun, Mar 22, 5:58 AM
imp accepted this revision.Sun, Mar 22, 2:57 PM

why 3.11+?
Otherwise looks good to me.

This revision is now accepted and ready to land.Sun, Mar 22, 2:57 PM
Closed by commit R11:15c5542e3e7a: devel/ghpr: add missing `BUILD_DEPENDS` (authored by ngie). · Explain WhySun, Mar 22, 3:59 PM
This revision was automatically updated to reflect the committed changes.
ngie added a commit: R11:15c5542e3e7a: devel/ghpr: add missing `BUILD_DEPENDS`.

Revision Contents
Changeset List

PathSize
devel/
ghpr/
5 lines

Diff 173941

View Options

devel/ghpr/Makefile

Loading...