zine-ssg is a static site generator similar to www/gohugo. There is a companion port, devel/superhtml with review available at D55878.
Details
Details
- Reviewers
adamw - Group Reviewers
Contributor Reviewers (ports) - Commits
- R11:e93d209b4fac: www/zine-ssg: Add port
In addition to make test, also ran poudriere testport -j FreeBSD15 -p local www/zine-ssg and will be attaching output.
NOTE: I do see a warning in the build log, but it matches the warning for zls (another zig port):
/!\ zine-ssg-0.11.2: Makefile warnings, please consider fixing /!\ MASTER_SITES contains https://github.com/AFLplusplus/AFLplusplus/archive/:AFLplusplus https://github.com/allyourcodebase/AFLplusplus/archive/:AFLplusplus ... https://github.com/kristoff-it/ziggy/archive/:ziggy, please use USE_GITHUB instead.
I'm assuming that is harmless.
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
I think I got the CONFLICTS_INSTALL right (misc/zine also wants to install /usr/local/bin/zine).
Comment Actions
Is it possible to fix the warning? If not that's fine.
| www/zine-ssg/Makefile | ||
|---|---|---|
| 21 | This should be DISTVERSIONPREFIX= v not GH_TAGNAME. | |
| 49 | If you wanted, this could also be written as cd ${BUILD_WRKSRC} && ${DO_MAKE_BUILD_TEST:N-d*:N--release=*} and avoid DO_MAKE_BUILD_TEST entirely. YMMV | |
| www/zine-ssg/pkg-descr | ||
| 9 | Is superhtml just to ease development? Or is it also of runtime benefit? If the former, I'd word that a little more clearly, and if the latter than maybe consider a SUPERHTML option? | |
| www/zine-ssg/pkg-descr | ||
|---|---|---|
| 9 | It just makes development easier. You don't have to have an LSP for zine. | |
Comment Actions
Use DISTVERSIONPREFIX not GH_TAGNAME=v${...}.
remove DO_MAKE_BUILD_TEST for test-target.
Comment Actions
I don't know how to get rid of the warning. I did a testbuild of zls to see if it had the issue too (it does). At that point I decided the issue is somewhere in Uses/zig.mk and I haven't had a chance to investigate.
| www/zine-ssg/Makefile | ||
|---|---|---|
| 49 | it was a little more involved. But I totally agree this is a better way that is less brittle to changes in Uses/zig.mk. | |
Comment Actions
I had a foo target I was using to quickly check the modified DO_MAKE_BUILD for do-test. That needed to be removed!
| www/zine-ssg/Makefile | ||
|---|---|---|
| 13 | If that's the case it's not a BUILD_DEPENDS, | |
| www/zine-ssg/Makefile | ||
|---|---|---|
| 13 | Thank you! Now that you pointed it out, of course its TEST_DEPENDS. updated. | |
Comment Actions
No worries about delay. One of my zig subtree repos just decided to up and move from github to codeberg (there will probably be more in the future since zig itself moved). Testing the fix now.