Page MenuHomeFreeBSD
Differential D819

Revert regression breaking linux- mozilla products
ClosedPublic
Actions

Authored by xmj on Sep 23 2014, 1:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 8:30 PM
Unknown Object (File)
Fri, Nov 29, 7:02 PM
Unknown Object (File)
Fri, Nov 29, 7:10 AM
Unknown Object (File)
Thu, Nov 28, 10:29 AM
Unknown Object (File)
Sun, Nov 24, 2:11 AM
Unknown Object (File)
Sat, Nov 23, 7:13 AM
Unknown Object (File)
Fri, Nov 22, 11:21 AM
Unknown Object (File)
Wed, Nov 20, 8:20 PM
View All Files
Subscribers
None

Details

Reviewers
swills
koobs
Summary

As reported in 193859, r368845 has introduced a regression through reverting
the logic of WANT_GTK218 checks as if c6 were already default.

Clear this up through restoring pre-368845 status quo.

Commitmessage:

Revert breaking Linux Mozilla suite with -f10

Revert a regression introduced in r368845 that causes Linux Mozilla suite not
to work until CentOS 6.5 is default.

PR: 193859
Submitted by: Jan Beich <jbeich@vfemail.net>
Approved by: swills (mentor)
Test Plan

poudriere says it builds fine:
http://xmj.me/freebsd/buildlogs/linux-firefox-32.0,1.log
http://xmj.me/freebsd/buildlogs/linux-seamonkey-2.29.log
http://xmj.me/freebsd/buildlogs/linux-thunderbird-31.1.0.log

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

xmj updated this revision to Diff 1733.Sep 23 2014, 1:20 PM
xmj retitled this revision from to Revert regression breaking linux- mozilla products.
xmj updated this object.
xmj edited the test plan for this revision. (Show Details)
xmj added reviewers: swills, koobs.
swills accepted this revision.Sep 23 2014, 9:27 PM
swills edited edge metadata.

Approved!

This revision is now accepted and ready to land.Sep 23 2014, 9:27 PM
xmj closed this revision.Sep 29 2014, 11:36 AM

Landed as 369157

Revision Contents
Changeset List

PathSize
www/
linux-seamonkey/
5 lines

Diff 1733

View Options

www/linux-seamonkey/Makefile.common

Loading...