lang/jpm: Update to 1.2.0
ClosedPublic
Actions

Authored by dave_freedave.net on Fri, Feb 20, 12:40 PM.

Details

Reviewers

hsw_bitmark.com
arrowd

Group Reviewers

Contributor Reviewers (ports)

Commits

R11:abd8416ab1a9: lang/jpm: Update to 1.2.0 and enable testing

Summary

Technically all that was needed was bumping the DISTVERSION, removing PORTREVISION, running make makesum, and adding a new file to pkg-plist.

But I wanted to have a way to quickly test, and both portlint -A and portclippy --strict Makefile had a few nits so I went ahead and addressed them.

Test Plan

I need an updated jpm(1) to build the latest spork (a popular janet library). While spork can be built without jpm(1) it does make for an easy test: verify jpm install works for spork which I have done.

Also added a do-test target and verified make test works.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dave_freedave.net requested review of this revision.Fri, Feb 20, 12:40 PM

dave_freedave.net created this revision.

dave_freedave.net mentioned this in D54667: devel/janet-lsp: Update to 0.0.12.Fri, Feb 20, 1:05 PM

Just ran poudriere testport -j FreeBSD15 -p local lang/jpm and could probably use NO_ARCH=yes like D54667.

===>   Building jpm-1.2.0
pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:15:amd64" -- no architecture specific files found:
**** could this package use a wildcard architecture?

add NO_ARCH=yes

it works for me of FreeBSD 15.0 RELEASE

This revision is now accepted and ready to land.Wed, Feb 25, 7:22 AM

hsw_bitmark.com added a reviewer: Contributor Reviewers (ports).Wed, Feb 25, 7:23 AM

arrowd added a subscriber: arrowd.Wed, Feb 25, 7:30 AM

arrowd added inline comments.

lang/jpm/Makefile
32	This looks wrong. The file always contains "/usr/local" while LOCALBASE may be set to something else. In this case sed would replace nothing.
42	Same here. If something always creates "/usr/local/..." then using the LOCALBASE variable is wrong.