Page MenuHomeFreeBSD
Differential D54461

emulators/qemu-devel: add slirp dependency
ClosedPublic
Actions

Authored by adrian on Fri, Jan 2, 11:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 11, 2:31 AM
Unknown Object (File)
Sat, Jan 10, 4:42 AM
Unknown Object (File)
Fri, Jan 9, 2:25 PM
Unknown Object (File)
Tue, Jan 6, 11:28 PM
Unknown Object (File)
Mon, Jan 5, 3:46 PM
Unknown Object (File)
Mon, Jan 5, 2:26 AM
Unknown Object (File)
Sat, Jan 3, 6:03 AM
Unknown Object (File)
Sat, Jan 3, 3:47 AM
View All 15 Files
Subscribers
None

Details

Reviewers
bofh
imp
Commits
R11:3c154fd0ad2b: emulators/qemu-devel: add slirp dependency
Summary

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69578
Build 66461: arc lint + arc unit

Event Timeline

adrian requested review of this revision.Fri, Jan 2, 11:23 PM
adrian created this revision.
Harbormaster completed remote builds in B69574: Diff 168920.Fri, Jan 2, 11:23 PM
adrian added a reviewer: bofh.Fri, Jan 2, 11:23 PM
imp accepted this revision.Fri, Jan 2, 11:39 PM
This revision is now accepted and ready to land.Fri, Jan 2, 11:39 PM
imp added a comment.Fri, Jan 2, 11:40 PM

Libfdt is there as a fallback. I think yhis is right

adrian retitled this revision from emulators/qemu-devel: add/fix library dependencies; remove libfdt installation to emulators/qemu-devel: add slirp dependency.Sat, Jan 3, 12:04 AM
adrian updated this revision to Diff 168923.Sat, Jan 3, 12:04 AM

just do slirp for now, bofh@ says the libfdt/meson internal use is intentional

This revision now requires review to proceed.Sat, Jan 3, 12:04 AM
Harbormaster completed remote builds in B69577: Diff 168923.Sat, Jan 3, 12:04 AM
adrian edited the summary of this revision. (Show Details)Sat, Jan 3, 12:05 AM
adrian updated this revision to Diff 168924.Sat, Jan 3, 12:06 AM
adrian edited the summary of this revision. (Show Details)

should be 1, not 2

Harbormaster completed remote builds in B69578: Diff 168924.Sat, Jan 3, 12:06 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sat, Jan 3, 12:44 AM
Closed by commit R11:3c154fd0ad2b: emulators/qemu-devel: add slirp dependency (authored by adrian). · Explain Why
This revision was automatically updated to reflect the committed changes.
adrian added a commit: R11:3c154fd0ad2b: emulators/qemu-devel: add slirp dependency.
bofh added a comment.Sat, Jan 10, 10:29 AM
In D54461#1244582, @imp wrote:

Libfdt is there as a fallback. I think yhis is right

I have checked this. So what happens is based on the fallouts in the dev eventually qemu team upstreams patches for libfdt which eventually lands in our libfdt ports. So running the qemu-devel version with the libfdt from their included branch makes more sense to me. As if there is any breakage with libfdt from qemu head branch qemu team will propose/merge these in upstream libfdt which will be used for our main qemu ports. But correct me if I am wrong.

What we can do is we can create a CONFLICTS_INSTALL with libfdt.

Revision Contents
Changeset List

PathSize
emulators/
qemu-devel/
4 lines

Diff 168924

View Options

emulators/qemu-devel/Makefile

Loading...