Fix Coverity CIDs 1356022, 1356034, 1356023, 1356035, 1356042
ClosedPublic
Actions

Authored by truckman on May 25 2016, 8:41 AM.

Tags

None

Referenced Files

	F111426090: D6558.diff
	Mon, Mar 3, 3:04 PM

	Unknown Object (File)
	Thu, Feb 27, 11:54 AM

	Unknown Object (File)
	Mon, Feb 24, 11:05 AM

	Unknown Object (File)
	Jan 9 2025, 1:50 AM

	Unknown Object (File)
	Oct 4 2024, 7:31 PM

	Unknown Object (File)
	Sep 18 2024, 6:37 PM

	Unknown Object (File)
	Sep 8 2024, 9:39 AM

	Unknown Object (File)
	Sep 8 2024, 6:07 AM

View All 33 Files

Subscribers

imp

Details

Reviewers

ken

Summary

Using the new CCB_CLEAR_ALL_EXCEPT_HDR() macro fixes
four of these issues.

CID 1356042 is a resource leak. Every time goto restart_report
is executed, cdb_storage is overwritten, leaking the buffer
that it previously pointed to.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3947
Build 3990: arc lint + arc unit

Event Timeline

truckman updated this revision to Diff 16855.May 25 2016, 8:41 AM

truckman retitled this revision from to Fix Coverity CIDs 1356022, 1356034, 1356023, 1356035, 1356042.

truckman updated this object.

truckman edited the test plan for this revision. (Show Details)

truckman added a reviewer: ken.

Herald added a subscriber: imp. · View Herald TranscriptMay 25 2016, 8:41 AM

Clear cdb_storage before reusing it.

Looks good, thank you!

This revision is now accepted and ready to land.May 25 2016, 12:11 PM

Closed by commit : rS300685: Fix a couple of new instances of a false positive Coverity buffer (authored by truckman).

Revision Contents
Changeset List

Path

Size

sbin/

camcontrol/

epc.c

3 lines

zone.c

8 lines

Diff 16856

View Options

sbin/camcontrol/epc.c