Page MenuHomeFreeBSD
Differential D54244

ufshci: Enable admin command retry
ClosedPublic
Actions

Authored by jaeyoon on Dec 16 2025, 5:31 AM.
Tags
None
Referenced Files
F148570980: D54244.diff
Wed, Mar 18, 8:36 PM
Unknown Object (File)
Mon, Mar 16, 2:09 AM
Unknown Object (File)
Mon, Mar 16, 2:08 AM
Unknown Object (File)
Mon, Mar 16, 2:08 AM
Unknown Object (File)
Mon, Mar 16, 2:07 AM
Unknown Object (File)
Thu, Mar 5, 11:10 AM
Unknown Object (File)
Sat, Feb 21, 5:01 AM
Unknown Object (File)
Feb 3 2026, 7:04 AM
View All 35 Files
Subscribers
None

Details

Reviewers
imp
Commits
rGece6e062ae4b: ufshci: Enable admin command retry
Summary

Also, This patch fixes an issue where the admin command flag was not
passed through.

Sponsored by: Samsung Electronic

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69287
Build 66170: arc lint + arc unit

Event Timeline

jaeyoon requested review of this revision.Dec 16 2025, 5:31 AM
jaeyoon created this revision.
Harbormaster completed remote builds in B69286: Diff 168166.Dec 16 2025, 5:31 AM
jaeyoon added a parent revision: D54243: ufshci: Fix task management queue num_trackers on failure path.Dec 16 2025, 5:31 AM
jaeyoon updated this revision to Diff 168167.Dec 16 2025, 5:36 AM

Remove is_admin = false in ufshci_ctrlr_submit_task_mgmt_request

Harbormaster completed remote builds in B69287: Diff 168167.Dec 16 2025, 5:36 AM
imp accepted this revision.Jan 2 2026, 4:57 AM

This looks good too... I'll be able to test this after the 15th

This revision is now accepted and ready to land.Jan 2 2026, 4:57 AM
jaeyoon added a comment.Jan 5 2026, 2:09 AM

Thank you for the review!

Closed by commit rGece6e062ae4b: ufshci: Enable admin command retry (authored by jaeyoon). · Explain WhyJan 5 2026, 2:39 AM
This revision was automatically updated to reflect the committed changes.
jaeyoon added a commit: rGece6e062ae4b: ufshci: Enable admin command retry.

Revision Contents
Changeset List

PathSize
sys/
dev/
ufshci/
17 lines
6 lines
3 lines
6 lines
7 lines
3 lines

Diff 168167

View Options

sys/dev/ufshci/ufshci_ctrlr.c

Loading...
View Options

sys/dev/ufshci/ufshci_ctrlr_cmd.c

Loading...
View Options

sys/dev/ufshci/ufshci_dev.c

Loading...
View Options

sys/dev/ufshci/ufshci_private.h

Loading...
View Options

sys/dev/ufshci/ufshci_req_queue.c

Loading...
View Options

sys/dev/ufshci/ufshci_sim.c

Loading...