Reported by: Robert Gogolok mastodon.bsd.cafe/@gogo
Obtained from: bapt
Sponsored by: SkunkWerks, GmbH
Details
Details
- Reviewers
dfr
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 67953 Build 64836: arc lint + arc unit
Event Timeline
Comment Actions
TLDR don't run golangci-lint as part of the build.
This was reported via mastodon for a user building from sources / make (i.e. not in poudriere).
Baptiste cooked up a patch, but because the sources live outside $WRKSRC the ports tree
doesn't know how to patch them, so .. sed instead. If you can think of a smarter way I'm
all ears.
diff diff --git a/sysutils/containers-common/files/patch-tests_tools_Makefile b/sysutils/containers-common/files/patch-tests_tools_Makefile new file mode 100644 index 000000000000..8fbd9833a463 --- /dev/null +++ b/sysutils/containers-common/files/patch-tests_tools_Makefile @@ -0,0 +1,12 @@ +--- tests/tools/Makefile.orig 2025-08-01 18:26:00 UTC ++++ tests/tools/Makefile +@@ -20,8 +20,7 @@ $(BUILDDIR): \ + + $(BUILDDIR): \ + $(BUILDDIR)/git-validation \ +- $(BUILDDIR)/go-md2man \ +- $(BUILDDIR)/golangci-lint ++ $(BUILDDIR)/go-md2man + + $(BUILDDIR)/git-validation: + $(call go-build,./vendor/github.com/vbatts/git-validation)
Comment Actions
Seems reasonable. We don't need to lint the source every time we build it - the upstream CI forces lint checks already.