Page MenuHomeFreeBSD
Differential D6237

libcrypto: add "Generated from" reference to source file
ClosedPublic
Actions

Authored by emaste on May 6 2016, 2:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 11:45 PM
Unknown Object (File)
Thu, Jan 16, 8:44 AM
Unknown Object (File)
Tue, Jan 14, 12:01 AM
Unknown Object (File)
Fri, Jan 10, 5:12 AM
Unknown Object (File)
Fri, Jan 10, 1:13 AM
Unknown Object (File)
Fri, Jan 10, 1:13 AM
Unknown Object (File)
Thu, Jan 9, 6:09 AM
Unknown Object (File)
Fri, Jan 3, 11:04 PM
View All Files
Subscribers
None

Details

Reviewers
jkim
Commits
rS299464: libcrypto: add "Do not modify" comment to generated source files
Summary

This will make it more obvious that these files should not be edited directly, and provide a hint for finding the real source file.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 15960.May 6 2016, 2:04 AM
emaste retitled this revision from to libcrypto: add "Generated from" reference to source file.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: jkim.
emaste mentioned this in D6164: Make this code position independent.May 6 2016, 3:32 PM
emaste added a comment.May 10 2016, 8:37 PM

Ping?

jkim requested changes to this revision.May 10 2016, 8:40 PM
jkim edited edge metadata.
jkim added inline comments.
secure/lib/libcrypto/Makefile.asm
60–61

This is not exactly correct. For example, both sha256-x86_64.S and sha512-x86_64.S are generated from sha512-x86_64.pl.

This revision now requires changes to proceed.May 10 2016, 8:40 PM
emaste added inline comments.May 10 2016, 8:43 PM
secure/lib/libcrypto/Makefile.asm
60–61

Oh, indeed. But, do you think (something like) this is a reasonable change with that addressed?

jkim added inline comments.May 10 2016, 8:52 PM
secure/lib/libcrypto/Makefile.asm
60–61

Yes. Maybe "Please do not modify. This file is auto-generated." kind of comment is enough, I think.

emaste updated this revision to Diff 16163.May 10 2016, 9:02 PM
emaste edited edge metadata.
  • use multiple echos as already done for i386 .S generation
  • remove the .cmt intermediate step
emaste updated this revision to Diff 16164.May 10 2016, 9:05 PM
emaste edited edge metadata.

Add "do not modify" text

emaste added inline comments.May 10 2016, 9:08 PM
secure/lib/libcrypto/Makefile.asm
60–61

Maybe "Please do not modify. This file is auto-generated." kind of comment is enough, I think.

Oh, perhaps. Although I think it's convenient to include the source file especially where the .S basename does not match the .pl.

Anyway, I don't have a strong feeling either way.

jkim added inline comments.May 10 2016, 9:14 PM
secure/lib/libcrypto/Makefile.asm
59

*.cmt must be removed from the above three lines.

emaste updated this revision to Diff 16166.May 10 2016, 9:20 PM

Remove .cmt files from CLEANFILES list

jkim added inline comments.May 10 2016, 9:33 PM
secure/lib/libcrypto/Makefile.asm
71

The x86-64 script requires the second argument for the output file because it needs to know whether it is creating sha256-x86_64.S or sha512-x86_64.S. That's why the intermediate files were created in the first place. :-(

emaste updated this revision to Diff 16167.May 10 2016, 9:44 PM

Don't try to be clever. Just put a 'Do not modify' comment.

jkim added inline comments.May 10 2016, 9:50 PM
secure/lib/libcrypto/Makefile.asm
145

Sorry for nit-picking but a blank is in the wrong place. :-)

emaste updated this revision to Diff 16198.May 11 2016, 12:53 PM

Fix whitespace

emaste marked an inline comment as done.May 11 2016, 12:54 PM
jkim accepted this revision.May 11 2016, 4:18 PM
jkim edited edge metadata.
This revision is now accepted and ready to land.May 11 2016, 4:18 PM
Closed by commit rS299464: libcrypto: add "Do not modify" comment to generated source files (authored by emaste). · Explain WhyMay 11 2016, 4:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
secure/
lib/
libcrypto/
29 lines

Diff 16163

View Options

secure/lib/libcrypto/Makefile.asm

Loading...