Page MenuHomeFreeBSD
Differential D51857

Fix incorrect dev being passed to gpiobus_detach_bus
ClosedPublic
Actions

Authored by devivanov_proton.me on Aug 10 2025, 5:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 25, 4:18 AM
Unknown Object (File)
Tue, Oct 21, 10:46 PM
Unknown Object (File)
Sat, Oct 18, 2:02 AM
Unknown Object (File)
Sat, Oct 11, 2:09 PM
Unknown Object (File)
Sat, Oct 11, 2:09 PM
Unknown Object (File)
Sat, Oct 11, 2:09 PM
Unknown Object (File)
Sat, Oct 11, 2:09 PM
Unknown Object (File)
Sat, Oct 11, 2:09 PM
View All 53 Files
Subscribers
imp
loos

Details

Reviewers
vexeduxr
imp
jhb
Commits
rG28bac28d9074: gpio: Fix incorrect dev being passed to gpiobus_detach_bus
Summary

Passing in the busdev will not detach from the bus correctly leaving the /dev/gpiocN entry

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 66176
Build 63059: arc lint + arc unit

Event Timeline

devivanov_proton.me created this revision.Aug 10 2025, 5:04 PM
Herald added subscribers: loos, imp. · View Herald TranscriptAug 10 2025, 5:04 PM
devivanov_proton.me requested review of this revision.Aug 10 2025, 5:04 PM
Harbormaster completed remote builds in B66153: Diff 160163.Aug 10 2025, 5:04 PM
imp added inline comments.Aug 10 2025, 5:19 PM
sys/dev/iicbus/gpio/pcf8574.c
160–161

Why test the busdev but detach dev

devivanov_proton.me updated this revision to Diff 160166.Aug 10 2025, 5:52 PM

Remove check for busdev before detaching from gpiobus

Harbormaster completed remote builds in B66156: Diff 160166.Aug 10 2025, 5:52 PM
imp accepted this revision.Aug 10 2025, 10:27 PM

This looks good to me, I'm adding a reviewer.

This revision is now accepted and ready to land.Aug 10 2025, 10:27 PM
imp added a reviewer: jhb.Aug 10 2025, 10:27 PM

So @jhb and @vexeduxr what do you think? From my tracing through of things, I think this is right, but I didn't do a super deep dive.

vexeduxr accepted this revision.Aug 11 2025, 12:11 AM
vexeduxr added inline comments.Aug 11 2025, 12:26 AM
sys/dev/iicbus/gpio/pcf8574.c
163

Why add a newline?

devivanov_proton.me updated this revision to Diff 160196.Aug 11 2025, 6:16 PM
devivanov_proton.me marked an inline comment as done.

Remove newline to confirm to the files format

This revision now requires review to proceed.Aug 11 2025, 6:16 PM
Harbormaster completed remote builds in B66176: Diff 160196.Aug 11 2025, 6:17 PM
vexeduxr accepted this revision.Aug 11 2025, 6:30 PM
This revision is now accepted and ready to land.Aug 11 2025, 6:30 PM
imp added a comment.Aug 11 2025, 10:47 PM

@vexeduxr can you include this with the other gpiobus changes you're doing? Let me know if you need any help with committing someone else's change.

vexeduxr added a comment.Aug 12 2025, 2:03 AM
In D51857#1185208, @imp wrote:

@vexeduxr can you include this with the other gpiobus changes you're doing? Let me know if you need any help with committing someone else's change.

Sure.

Closed by commit rG28bac28d9074: gpio: Fix incorrect dev being passed to gpiobus_detach_bus (authored by devivanov_proton.me, committed by vexeduxr). · Explain WhyAug 13 2025, 11:33 AM
This revision was automatically updated to reflect the committed changes.
vexeduxr added a commit: rG28bac28d9074: gpio: Fix incorrect dev being passed to gpiobus_detach_bus.

Revision Contents
Changeset List

PathSize
sys/
dev/
iicbus/
gpio/
4 lines
4 lines

Diff 160196

View Options

sys/dev/iicbus/gpio/pcf8574.c

Loading...
View Options

sys/dev/iicbus/gpio/tca64xx.c

Loading...