[geom_uzip] Correct usage of GEOM_UZIP_DEBUG
ClosedPublic
Actions

Authored by mizhka on May 4 2016, 6:11 PM.

Details

Reviewers

Commits

rS299195: Add missing include "opt_geom.h" to make GEOM_UZIP_DEBUG option working,

Summary

The "option GEOM_UZIP_DEBUG" do nothing right now due to missing include.
This patch added include of "opt_geom.h" into sys/geom/g_uzip.c and rename enum values to avoid naming conflicts.

Test Plan

Tested on Asus RT-N53.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mizhka updated this revision to Diff 15899.May 4 2016, 6:11 PM

mizhka retitled this revision from to [geom_uzip] Correct usage of GEOM_UZIP_DEBUG .

mizhka updated this object.

mizhka edited the test plan for this revision. (Show Details)

mizhka added a reviewer: sobomax.

mizhka set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptMay 4 2016, 6:11 PM

Same diff, but with more context (U9999)

sobomax accepted this revision.May 6 2016, 7:33 PM

sobomax edited edge metadata.

This revision is now accepted and ready to land.May 6 2016, 7:33 PM

sobomax added inline comments.May 6 2016, 7:34 PM

sys/geom/uzip/g_uzip.c
32 ↗	(On Diff #15924)	I think it's good practice to do "local" includes after system includes.

mizhka added inline comments.May 6 2016, 8:02 PM

sys/geom/uzip/g_uzip.c
32 ↗	(On Diff #15924)	Thanks! I'll update diff tomorrow )

Closed by commit rS299195: Add missing include "opt_geom.h" to make GEOM_UZIP_DEBUG option working, (authored by sobomax). · Explain WhyMay 6 2016, 8:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

geom/

uzip/

g_uzip.c

12 lines

Diff 15993

View Options

head/sys/geom/uzip/g_uzip.c

[geom_uzip] Correct usage of GEOM_UZIP_DEBUG ClosedPublicActions